Allow flashing binary to a named partition #828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioGasquez
approved these changes
Apr 4, 2025
Member
SergioGasquez
left a comment
SergioGasquez
left a comment
There was a problem hiding this comment.
LGTM! Could we add a HIL test for this?
Contributor
Author
|
whoops that's a different pr 🙈 |
bugadani
force-pushed
the
partition
branch
2 times, most recently
from
e52cb98 to
4602be6
Compare
SergioGasquez
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #631
This PR allows specifying a partition label for
write-bin, in addition to a numeric address. If a partition label is passed, espflash tries to parse the provided/configured partition table, and resolve the label. This information is then used to a) check the size of the flashed binary and b) specify the address where the binary should be written.As an alternative approach, we might read back the partition table from the device itself. Since users have the option to configure a partition table in a config file, this option would need a
--read-idf-partition-table-from-deviceor similar flag, meaning it can still be implemented without breaking the command's current behaviour.