Skip to content

Remove the dependency on xmas_elf #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SergioGasquez merged 1 commit into from
Mar 28, 2025
Merged

Remove the dependency on xmas_elf #821

SergioGasquez merged 1 commit into from
Mar 28, 2025

Conversation

@jessebraham
Copy link
Member

@jessebraham jessebraham commented Mar 28, 2025

While these changes technically have user-facing effects, we need to remove ElfFile from the public API anyway so I will not add a CHANGELOG.md entry here, since it will just be obsolete once #803 is resolved anyway.

@jessebraham jessebraham added the skip-changelog Skips the changelog CI check label Mar 28, 2025
SergioGasquez
SergioGasquez approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SergioGasquez SergioGasquez added this pull request to the merge queue Mar 28, 2025
@jessebraham jessebraham mentioned this pull request Mar 28, 2025
Closed
Merged via the queue into esp-rs:main with commit 5541355 Mar 28, 2025
25 checks passed
@jessebraham jessebraham deleted the fixes/remove-xmas-elf branch March 28, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees

No one assigned

Labels

skip-changelog Skips the changelog CI check

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jessebraham @SergioGasquez