Add chip detection using security info #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebraham
force-pushed
the
feature/chip-detect
branch
6 times, most recently
from
80976b2 to
e6b6f95
Compare
jessebraham
force-pushed
the
feature/chip-detect
branch
from
e6b6f95 to
bb1178d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs more testing, so opening as draft for now; would like to see the HIL results. EDIT: Seems I've broken something 😁
Also am not in love with the current
TryFromimplementation forChip, as it's yet another place that needs updating when adding chip support, but it gets the job done at least. Maybe we can come up with something better, will sleep on it.Closes #767