Add ROM version of read-flash command
#812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
playfulFence
force-pushed
the
read_flash
branch
from
a45c455 to
c8dee7d
Compare
jessebraham
reviewed
Mar 21, 2025
Comment on lines
37
to
43
| echo "Testing ROM read-flash with length: $len" | ||
| result=$(espflash read-flash --no-stub 0 "$len" flash_content.bin 2>&1) | ||
| echo "$result" | ||
| if [[ ! $result =~ "Flash content successfully read and written to" ]]; then | ||
| echo "Failed to read $len bytes from flash" | ||
| exit 1 | ||
| fi |
Member
There was a problem hiding this comment.
Could we verify the flash contents for this test as well please?
Member
Author
There was a problem hiding this comment.
Haha damn, totally forgot about it, sorry 😆
Will push the change in no time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #757