Detect log format metadata #809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SergioGasquez
left a comment
SergioGasquez
left a comment
There was a problem hiding this comment.
Changes looks good so far, we should update/add a hil test for this
bugadani
force-pushed
the
metadata
branch
2 times, most recently
from
a3cf625 to
1a81bf6
Compare
Contributor
Author
Should I do it manually now, or wait until the changes reach an esp-hal/esp-generate release? |
Member
Both work for me, tbh. The comment was just a reminder so we dont forget to add it. I guess we could wait for changes to be released |
bugadani
force-pushed
the
metadata
branch
4 times, most recently
from
dfb4687 to
2078f7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR for esp-rs/esp-hal#3276