Minor error handling and function naming improvements #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioGasquez
approved these changes
Feb 28, 2025
Member
SergioGasquez
left a comment
SergioGasquez
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the cleanups!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing major here, just some simple cleanup:
get_prefix fromget_usb_pid, remove uselessResultfrom return typeStill a bit of untangling to do with regards to some imports from
flasherin theconnectionmodule, but it's looking mostly okay I think. Not clear to me how to resolve those yet so will deal with it another time.