Fix write-bin padding #788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioGasquez
force-pushed
the
fix/bin-padding
branch
from
7432306 to
c6ec31d
Compare
SergioGasquez
force-pushed
the
fix/bin-padding
branch
3 times, most recently
from
6b66339 to
dd9e4b0
Compare
SergioGasquez
force-pushed
the
fix/bin-padding
branch
from
dd9e4b0 to
6c4cfd1
Compare
SergioGasquez
commented
Feb 26, 2025
MabezDev
approved these changes
Feb 26, 2025
Member
MabezDev
left a comment
MabezDev
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding a HIL test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing if #622 was resolved by #780, I noticed that #780 failed to flash a non-4-padded bin on the first try, the second would work as it would write the padding to the bin.
I updated the padding mechanism to not write the binary and it now works also on the first iteration.
Also added a HIL test.