add --monitor option to write-bin
#783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioGasquez
requested changes
Feb 27, 2025
Member
SergioGasquez
left a comment
SergioGasquez
left a comment
There was a problem hiding this comment.
Changes LGTM! But Id love to have some HIL for this, at the moment, we do the following:
https://github.com/esp-rs/espflash/blob/main/.github/workflows/hil.yml#L114-L117, we could avoid using the monitor.sh by using the --monitor flag on the save-image_write-bin.sh and verifying the output!
playfulFence
force-pushed
the
main
branch
2 times, most recently
from
87d0742 to
d0247f4
Compare
increase timeout even more
Co-authored-by: Sergio Gasquez Arcos <[email protected]>
increase timer
SergioGasquez
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #684