Normalize similar arguments #759
Conversation
|
Shall I also edit the other places of the codebase where we use |
SergioGasquez
force-pushed
the
feat/arguments
branch
4 times, most recently
from
667f557 to
8824e55
Compare
|
Id like to come up with better names for monitoring args:
Here is what esptool does: #736 |
SergioGasquez
force-pushed
the
feat/arguments
branch
from
8824e55 to
f9a34a2
Compare
For the moment, I'm using |
| no_reset: bool, | ||
| /// Logging format. | ||
| #[arg(long, short = 'L', default_value = "serial", requires = "elf")] | ||
| #[arg(long, short = 'L', default_value = "serial")] |
There was a problem hiding this comment.
I removed the requires because it was failing when using it as a custom runner, since you have the elf from the image, but dont have the elf arg.
You still get a pretty decent error when you do espflash monitor --log-format defmt and dont provide and elf:
❯ cargo r -r --bin espflash -- monitor --log-format defmt
...
Commands:
CTRL+R Reset chip
CTRL+C Exit
Error: espflash::monitor::defmt::no_elf
× No elf data available
help: Please provide an ELF file with the `--elf` argument
But you get that after selecting the port
There was a problem hiding this comment.
Maybe we could investigate improving this in #764, since is somewhat similar
There was a problem hiding this comment.
It's also an issue in that espflash flash <image> --elf <image> is meaningless, but it's allowed.
4 participants
I also removed some short arguments that didnt make much sense to me (I can revert those)