Improve HIL #754
Merged
Improve HIL #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioGasquez
force-pushed
the
ci/hil
branch
6 times, most recently
from
12fb4b2 to
d177e92
Compare
SergioGasquez
force-pushed
the
ci/hil
branch
6 times, most recently
from
b822f81 to
08993c0
Compare
Merged
SergioGasquez
force-pushed
the
ci/hil
branch
from
08993c0 to
6a40571
Compare
jessebraham
approved these changes
Feb 10, 2025
Member
jessebraham
left a comment
jessebraham
left a comment
There was a problem hiding this comment.
A couple little nitpicks but overall looking good, thanks for fighting through all the issues with this!
Co-authored-by: Jesse Braham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves a bit our HIL tests:
erase-region,hold-in-reset,checksum-md5andreset