If a port was specified via CLI or config, search *all* serial ports, not just the filtered list #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not just the filtered list
SergioGasquez
approved these changes
Oct 24, 2024
Member
SergioGasquez
left a comment
SergioGasquez
left a comment
There was a problem hiding this comment.
Changes LGTM! Let's wait for the confirmation that it fixes the issue. Thanks!
|
Confirmed that the patch fixed the issue. Tested with By the way, it is always impressive how quickly espressif responds to issues and reports. Other vendors should follow the same practice. |
Member
Author
|
Thank you for confirming the fix, and for the kind words! There are still some additional small changes I'd like to make, but I hope to publish new releases next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the list of available ports were being filtered down by default, when specifying a port via CLI option or configuration file which had been filtered out, the port was reported as unavailable. This should resolve the issue by only filtering the list of ports if no port was specified.
@trombik are you able to test this branch out and confirm that it indeed resolves the issue for you, please?
Closes #692