Update download mode detection #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this failed to detect download mode during this regex match in the following message.
```
ESP-ROM:esp32s3-20210327
Build:Mar 27 2021
rst:0x1 (POWERON),boot:0x0 (DOWNLOAD(USB/UART0))
waiting for download
```
`.*` only matches on any character EXCEPT line breaks, where as [\s\S]` will match on anything.
Member
SergioGasquez
left a comment
SergioGasquez
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Although its only one line, it probably deserves a changelog entry. Mind adding it?
Co-authored-by: Sergio Gasquez Arcos <[email protected]>
Member
|
What is going on with CI? It was passing before, I just updated the Changelog. Sorry about that 😅 |
Member
I think it wasn't passing before, |
Contributor
Author
|
ci is green! |
NeaguSorin
approved these changes
Oct 9, 2024
NeaguSorin
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this failed to detect download mode during this regex match in the following message.
.*only matches on any character EXCEPT line breaks, where as[\s\S]will match on anything.