Skip to content

Add value_parser so partition-table-offset accepts offset expressed in hexadecimal. #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SergioGasquez merged 2 commits into from
Sep 17, 2024
Merged

Add value_parser so partition-table-offset accepts offset expressed in hexadecimal. #682

SergioGasquez merged 2 commits into from
Sep 17, 2024

Conversation

@jnross
Copy link
Contributor

@jnross jnross commented Sep 17, 2024

No description provided.

SergioGasquez
SergioGasquez approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Changes lgtm and did a small test where everything worked as expected!

@SergioGasquez SergioGasquez added this pull request to the merge queue Sep 17, 2024
Merged via the queue into esp-rs:main with commit 62cec88 Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jnross @SergioGasquez