Display timestamp, useful to find timing problem #680
Conversation
SergioGasquez
left a comment
SergioGasquez
left a comment
There was a problem hiding this comment.
Does this show the log level and line? Also, what is the format when not using embassy and the selected feature for timestamps?
Yes, it shows the log level and line too. Using same display code from defmt.
Display rest of info without timestamp. |
|
Did some testing in the PR and changes the IMHO, the new format lacks of a separator between the level and the message. Is that the default |
Yes, here is an image of defmt |
SergioGasquez
left a comment
SergioGasquez
left a comment
There was a problem hiding this comment.
Mind resolving the conflicts?
jessebraham
left a comment
jessebraham
left a comment
There was a problem hiding this comment.
I've resolved the conflict, changes seem fine to me. @SergioGasquez will give you final say on this and let you merge it if you approve :)
SergioGasquez
left a comment
SergioGasquez
left a comment
There was a problem hiding this comment.
Thanks for the contribution! And thanks for resolving the conflict @jessebraham!
3 participants
I found timestamp in defmt documents, but following their instruction still don't show timestamp.
Spent a week figured out it's because espflash didn't display it.
This change made following work too
in Cargo.toml dependency:
embassy-time ={ version = "0.3.1" , features = ["defmt-timestamp-uptime"] }