Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

Upgrade: typescript-estree ^5.3.0 #573

Closed
kaicataldo wants to merge 1 commit into from
Closed

Upgrade: typescript-estree ^5.3.0 #573

kaicataldo wants to merge 1 commit into from

Conversation

@kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Nov 29, 2018 •
edited
Loading

This PR updates typescript-estree to the most recent release. Of note is this addition: JamesHenry/typescript-estree@8787f16

Is there a reason we want to lock the version? It seems like we should be able to use ^, as the project follows semver.

@kaicataldo kaicataldo removed the triage label Nov 29, 2018
@kaicataldo kaicataldo force-pushed the update-typescript-estree branch 3 times, most recently from fff30b5 to 0eb1162 Compare November 30, 2018 23:16
@kaicataldo kaicataldo changed the title Upgrade: typescript-estree ^5.2.0 Upgrade: typescript-estree ^5.4.0 Nov 30, 2018
@kaicataldo kaicataldo changed the title Upgrade: typescript-estree ^5.4.0 Upgrade: typescript-estree ^5.3.0 Nov 30, 2018
@kaicataldo kaicataldo force-pushed the update-typescript-estree branch 2 times, most recently from de4a5f4 to 27eb62b Compare November 30, 2018 23:32
@mysticatea mysticatea mentioned this pull request Dec 1, 2018
Merged
mysticatea
mysticatea reviewed Dec 1, 2018
View reviewed changes
@platinumazure
Copy link
Member

platinumazure commented Dec 3, 2018

@kaicataldo Oops, I introduced conflicts here by merging #574 (which upgraded to typescript-estree 5.3.0 with no caret). Sorry, but would you mind rebasing or merging in upstream changes when you have time?

@platinumazure platinumazure mentioned this pull request Dec 3, 2018
Closed
@kaicataldo kaicataldo force-pushed the update-typescript-estree branch from 27eb62b to 1082067 Compare December 3, 2018 15:55
@kaicataldo kaicataldo force-pushed the update-typescript-estree branch from 1082067 to 696c1c8 Compare December 3, 2018 15:56
@kaicataldo
Copy link
Member Author

kaicataldo commented Dec 3, 2018

Now that #567 has landed and the project is already using typescript-estree v5.3.0, I'm not sure how much value I'm adding here. But I do think using ^ makes sense! Thoughts?

@kaicataldo
Copy link
Member Author

kaicataldo commented Dec 3, 2018

On second thought, I'm just going to go ahead and close this. Let's re-evaluate whether we want to auto update minor versions the next time we upgrade.

@kaicataldo kaicataldo closed this Dec 3, 2018
@kaicataldo kaicataldo deleted the update-typescript-estree branch December 3, 2018 16:03
@corbinu
Copy link

corbinu commented Dec 3, 2018

@kaicataldo I would also think that the ^ would help. I would think you could switch this or create another PR now that 6.0.0 is out and add the caret then

@armano2
Copy link
Contributor

armano2 commented Dec 3, 2018

6.0.0 has breaking changes

@corbinu
Copy link

corbinu commented Dec 3, 2018

Yes I was suggesting a PR could be opened for it now though and we could handle the caret change on that one.

@kaicataldo kaicataldo mentioned this pull request Dec 6, 2018
Closed
nevir added a commit to nevir/typescript-eslint-parser that referenced this pull request Dec 7, 2018
@nevir
^ style dependency for typescript-estree. Ref: eslint#573 (comment)
d1c5de3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@armano2 armano2 armano2 left review comments

@mysticatea mysticatea mysticatea left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kaicataldo @platinumazure @corbinu @armano2 @mysticatea