New: Configuring core options in Config Files #22

mysticatea · 2019-05-12T03:30:26Z

Rendered RFC

Summary

This RFC adds several properties into config files to configure core options. People can use config files (including shareable configs!) instead of CLI options in order to configure some linter behavior.

Related Issues

eslint/eslint#3529 - Set ignore path in .eslintrc
eslint/eslint#4261 - combine .eslintignore with .eslintrc?
eslint/eslint#8824 - Allow config to ignore comments that disable rules inline
eslint/eslint#9382 - Proposal: reportUnusedDisableDirectives in config files
eslint/eslint#10341 - do not ignore files started with . by default
eslint/eslint#10891 - Allow setting ignorePatterns in eslintrc
eslint/eslint#11665 - Add top-level option for noInlineConfig or allowInlineConfig

not-an-aardvark

Thanks for working on this RFC! I left a few thoughts.

designs/2019-linter-options/README.md

mysticatea · 2019-05-23T07:57:25Z

@not-an-aardvark Thank you for your feedback. I updated this RFC. I think it has addressed your concerns.

aladdin-add · 2019-06-07T12:20:55Z

the rendered link seems broken.

mysticatea · 2019-06-07T18:08:21Z

Oh, thank you. I have fixed the link.

mysticatea · 2019-06-17T08:14:22Z

I have updated this RFC for some feedback.

Move coreOptions.* properties to top-level.
Disallow ignorePatterns in overrides entries to avoid confusion with excludedFiles property.

platinumazure

No concerns from me at this point.

mysticatea · 2019-06-27T14:28:56Z

@kaicataldo @not-an-aardvark Does the latest update solve your concerns? If so, I will move this RFC to the final commenting.

kaicataldo

Just one question about renaming property names, but otherwise this LGTM. Thanks for working on this!

designs/2019-core-options/README.md

New: The linterOptions property in Config Files

b813a35

mysticatea added feature Initial Commenting This RFC is in the initial feedback stage labels May 12, 2019

mysticatea added 2 commits May 12, 2019 12:44

fix wrong code

7589c38

tweak a sentence

6cf4ac5

not-an-aardvark reviewed May 12, 2019

View reviewed changes

mysticatea mentioned this pull request May 12, 2019

Support specifying extensions in the config eslint/eslint#10828

Closed

mysticatea added 5 commits May 12, 2019 19:56

add merge strategy of ignorePatterns

11be4a5

add about CLIEngine#isPathIgnored(filePath)

82c3f59

linterOptions → coreOptions

2b8f5c8

add a FAQ: excludedFiles and ignorePatterns

3a9d2d8

add about default ignoring

3a9567e

mysticatea changed the title ~~New: The linterOptions property in Config Files~~ New: The coreOptions property in Config Files May 12, 2019

add RFC PR

315a156

mysticatea mentioned this pull request May 15, 2019

6.0.0-alpha.1 tries to process configuration files in ignored directories eslint/eslint#11724

Closed

mysticatea added 3 commits May 23, 2019 16:38

make reportUnusedDisableDirectives cannot fail CI

8b7f6ae

allowInlineConfig → disableInlineConfig: make the default false.

dfa1432

add warnings about disableInlineConfig

55612c0

mysticatea added 2 commits June 7, 2019 19:11

move file

621c2e7

add about verifyOnRecoverableParsingErrors

6eae6df

unwrap coreOptions property

55706c1

mysticatea changed the title ~~New: The coreOptions property in Config Files~~ New: Configuring core options in Config Files Jun 17, 2019

fix typo

fdb0bf6

platinumazure approved these changes Jun 22, 2019

View reviewed changes

kaicataldo reviewed Jun 27, 2019

View reviewed changes

designs/2019-core-options/README.md Outdated Show resolved Hide resolved

designs/2019-core-options/README.md Show resolved Hide resolved

snyk-bot mentioned this pull request Oct 13, 2019

[Snyk] Upgrade eslint from 6.3.0 to 6.5.1 thinkwee/thinkwee.github.io#25

Closed

This was referenced Oct 22, 2019

[Snyk] Upgrade eslint from 6.3.0 to 6.5.1 thinkwee/thinkwee.github.io#28

Merged

[Snyk] Upgrade eslint from 4.10.0 to 6.5.1 ajesse11x/marketplace#1

Open

mysticatea mentioned this pull request Nov 8, 2019

New: Add resolveRelativeToConfigFile setting #46

Closed

This was referenced Nov 9, 2019

[Snyk] Upgrade eslint from 4.19.1 to 6.6.0 rubarb666/rails#3

Open

[Snyk] Upgrade eslint from 3.19.0 to 6.6.0 rubarb666/git-sketch-plugin#2

Open

mysticatea mentioned this pull request Nov 18, 2019

New: First-Class Support For .eslintrc.ts #50

Closed

snyk-bot mentioned this pull request Nov 21, 2019

[Snyk] Upgrade eslint from 6.3.0 to 6.6.0 WealthWizardsEngineering/service-registry#12

Merged

mysticatea mentioned this pull request Nov 22, 2019

Config File Simplification #9

Merged

snyk-bot mentioned this pull request Dec 1, 2019

[Snyk] Upgrade eslint from 6.6.0 to 6.7.0 basics/vector#111

Merged

snyk-bot mentioned this pull request Dec 11, 2019

[Snyk] Upgrade eslint from 6.7.0 to 6.7.2 basics/vector#113

Merged

snyk-bot mentioned this pull request Feb 13, 2020

[Snyk] Upgrade eslint from 6.5.1 to 6.8.0 thinkwee/thinkwee.github.io#39

Merged

snyk-bot mentioned this pull request Feb 27, 2020

[Snyk] Upgrade eslint from 5.15.1 to 6.8.0 alxtford/numconv#46

Merged

a-martynovich mentioned this pull request Mar 10, 2020

[Snyk] Upgrade eslint from 6.0.0 to 6.8.0 WoTTsecurity/api#773

Merged

This was referenced Mar 11, 2020

[Snyk] Upgrade eslint from 6.0.0 to 6.8.0 WealthWizardsEngineering/instance-terminator#10

Merged

[Snyk] Upgrade eslint from 6.3.0 to 6.8.0 O330oei/node#4

Open

This was referenced Apr 3, 2020

[Snyk] Upgrade eslint from 5.4.0 to 6.8.0 LuisAlejandro/luisalejandro.github.io-legacy#79

Merged

[Snyk] Upgrade eslint from 6.2.0 to 6.8.0 CollageLabs/collagelabs.org#58

Merged

This was referenced Oct 5, 2020

Bump eslint from 6.1.0 to 6.2.0 in /backend Ocelot-Social-Community/Ocelot-Social#1288

Closed

Bump eslint from 6.2.2 to 6.3.0 in /backend Ocelot-Social-Community/Ocelot-Social#1443

Closed

mdjermanovic mentioned this pull request Mar 15, 2021

/* eslint-expect-error */ — continuous verification of eslint config eslint/eslint#14212

Closed

mdjermanovic mentioned this pull request Jun 14, 2021

Chore: enable reportUnusedDisableDirectives in eslint-config-eslint eslint/eslint#14699

Merged

1 task

bmish mentioned this pull request Dec 9, 2022

feat!: flexible config + default reporting of unused disable directives #100

Merged

Uh oh!

New: Configuring core options in Config Files #22

New: Configuring core options in Config Files #22

Uh oh!

Conversation

mysticatea commented May 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Issues

Uh oh!

not-an-aardvark left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mysticatea commented May 23, 2019

Uh oh!

aladdin-add commented Jun 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mysticatea commented Jun 7, 2019

Uh oh!

mysticatea commented Jun 17, 2019

Uh oh!

platinumazure left a comment

Choose a reason for hiding this comment

Uh oh!

mysticatea commented Jun 27, 2019

Uh oh!

kaicataldo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mysticatea commented May 12, 2019 •

edited

Loading

aladdin-add commented Jun 7, 2019 •

edited

Loading