feat: Add eslint/core package#68
Conversation
Co-authored-by: Milos Djermanovic <[email protected]>
There was a problem hiding this comment.
[Docs] Following #52, it'd be good to have a decision doc for licensing. Even if it's just "we need / want to use the same as existing ESLint licenses".
There was a problem hiding this comment.
There was no decision made. The OpenJS Foundation says any new projects must be licensed under Apache 2.0.
There was a problem hiding this comment.
Is there a source that can be linked?
There was a problem hiding this comment.
Linked from where?
And I have no idea. We've been part of the foundation for a long time and this was communicated early on.
There might be something somewhere in https://github.com/openjs-foundation if you feel like going on a search.
There was a problem hiding this comment.
Linked from where?
Proposal: a decision doc, for visibility?
Co-authored-by: Milos Djermanovic <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]>
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
(posting some quick comment-questions in lieu of a full review)
There was a problem hiding this comment.
We weren't consulted on the creation of @types/eslint, so I consider those to be non-canonical types. As we move forward, we'll be creating types the way we want and using those. Maybe @types/eslint will get smart and start importing our types to flesh out the package, but either way, I'm not going to worry too much about it.
There was a problem hiding this comment.
non-canonical types
Practically speaking, those and typescript-eslint are canonical types, as those are what the entire community uses at the moment. If the decision is to explicitly not attempt backwards compat, sure, that's a reasonable decision - but I don't think they can be ignored in decision-making summarily.
Co-authored-by: Josh Goldberg ✨ <[email protected]>
Co-authored-by: Milos Djermanovic <[email protected]> Co-authored-by: Josh Goldberg ✨ <[email protected]>
Prerequisites checklist
What is the purpose of this pull request?
This package creates the
@eslint/corepackage, which is the future home of the runtime-agnostic rewritten core of ESLint.Right now it just exports types for language plugins.
What changes did you make? (Give an overview)
Related Issues
fixes #62
Is there anything you'd like reviewers to focus on?
I wasn't sure if we should be testing the type definitions somehow? I'd defer to someone with more TypeScript knowledge than I on how that might be done.