fix: avoid mutating object schema definitions during construction#412
Merged
fix: avoid mutating object schema definitions during construction#412
Conversation
mdjermanovic
approved these changes
Mar 23, 2026
Member
mdjermanovic
left a comment
There was a problem hiding this comment.
LGTM, thanks! Leaving this open for a couple more days in case anyone else would like to review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What did you do?
Constructed an
ObjectSchemafrom a definitions object and then checked the original object afterward.What did you expect to happen?
The original definitions object should remain unchanged.
What actually happened?
The constructor normalized the definitions in place and replaced the original string values with functions.
What is the purpose of this pull request?
This PR prevents
ObjectSchemafrom mutating caller-provided schema definitions during construction.What changes did you make? (Give an overview)
definitionsobject.Related Issues
Is there anything you'd like reviewers to focus on?