fix: correct ValidationStrategy parameter types#406
Merged
Conversation
fasttime
reviewed
Mar 24, 2026
Member
fasttime
left a comment
fasttime
left a comment
There was a problem hiding this comment.
Maybe this change should be tagged "fix:" because it changes the type of some exported function parameters from any to unknown.
Pixel998
changed the title
Contributor
Author
|
I’ve updated the title to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
This PR adds type-level test coverage for
ValidationStrategyand updates the JSDoc parameter types tounknown.What changes did you make? (Give an overview)
*tounknownfor all validation methods.ValidationStrategytype tests.Related Issues
#316 (comment)
Is there anything you'd like reviewers to focus on?