feat: Add config types in @eslint/core#237
Merged
mdjermanovic merged 15 commits intomainfrom Aug 27, 2025
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Copied config-related types over from the
eslintpackage into@eslint/coreWhat changes did you make? (Give an overview)
package.jsonfiles inpackages/compat,packages/config-helpers, andpackages/migrate-configto move@eslint/coreto thedependenciessection, ensuring it is available at runtime. [1] [2] [3]eslinttype imports with@eslint/coreinpackages/compat/src/fixup-rules.js,packages/compat/src/ignore-file.js,packages/config-helpers/src/define-config.js,packages/config-helpers/src/global-ignores.js,packages/config-helpers/src/types.ts, andpackages/migrate-config/src/migrate-config.js. This includes updates to typedefs likeConfig,Plugin,RuleEntry, and others to their corresponding@eslint/corecounterparts. [1] [2] [3] [4] [5] [6]RuleEntrytoRuleConfigandLinter.ConfigtoConfigObject. [1] [2]@typescript-eslint/array-typeto enforce consistent array type definitions in TypeScript files. The rule is configured to usegenericfor default array types andarrayfor readonly arrays.Related Issues
fixes #226
Is there anything you'd like reviewers to focus on?