feat!: Require Node.js ^20.19.0 || ^22.13.0 || >=24#561
Conversation
aladdin-add
force-pushed
the
feat/drop-node-18
branch
from
809bb1d to
9bb0768
Compare
fasttime
left a comment
fasttime
left a comment
There was a problem hiding this comment.
LGTM, thanks! Waiting for another approval.
|
I think it would be nice if we could move forward with it, since the CSS and JSON repositories have already merged their Node.js version update PRs. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Node.js version requirements to drop support for Node.js 18.x and establish new minimum versions for the supported release lines. The change aligns the package with ESLint's current Node.js support policy.
- Updates minimum Node.js requirement to ^20.19.0 || ^22.13.0 || >=24
- Removes Node.js 18.x from the CI test matrix
- Updates CI workflow to use specific minimum versions and LTS for platform-specific tests
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Updates engines field to require Node.js ^20.19.0 || ^22.13.0 || >=24, dropping Node.js 18.x support |
| .github/workflows/ci.yml | Removes Node.js 18.x from test matrix, adds 20.19.0 as minimum test version, and changes Windows/macOS to use lts/* |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lumirlumir
left a comment
lumirlumir
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Would like @eslint/eslint-tsc to re-verify and merge it, since it's a breaking change.
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Prerequisites checklist
What is the purpose of this pull request?
Updated package.json of the package to require:
"node": "^20.19.0 || ^22.13.0 || >=24"
This drops support for Node.js 18.
What changes did you make? (Give an overview)
Related Issues
refs eslint/eslint#19969
Is there anything you'd like reviewers to focus on?