Conversation
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "files": ["src/index.js"], | |||
| "include": ["src/**/*.js", "src/**/*.ts"], | |||
There was a problem hiding this comment.
If we use the files field, glob patterns are not supported.
snitin315
left a comment
snitin315
left a comment
There was a problem hiding this comment.
This has changed the dist directory structure.
Before
After
|
So the package export's aren't valid anymore: Lines 11 to 24 in 589323f |
|
@snitin315 Thanks for sharing the context. However, the changes you mentioned originate from #383, not from this PR. (I believe the latest changes from #383 are not yet reflected in your local environment.) Even if we revert the changes in this PR, the
That’s exactly why #383 was marked as a breaking change — the file structure in the dist folder was changed in that PR. |
|
Ah! Got it, thanks for the explanation. My local main branch was outdated. |
snitin315
deleted the
chore-fix-tsconfig-json-to-include-js-and-ts-files-in-src-dir
branch
2 participants
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I’ve updated the
tsconfig.jsonfile to include all.jsand.tsfiles in thesrcdirectory.Previously, due to the changes introduced in #383, type checking was only applied to
src/index.js, and the rest of thesrcdirectory was skipped. As a result, newly added rules and other files did not benefit from type checking.Here’s a minimal way to reproduce the issue:
Create a
test.jsfile atsrc/rules/test.js:The
Setdoesn’t have apushmethod, but type checking doesn’t catch this error.After updating the
tsconfig.json:Type checking works as intended.
What changes did you make? (Give an overview)
Related Issues
Is there anything you'd like reviewers to focus on?