fix: replace IMarkdownSourceCode with MarkdownSourceCode#336
Merged
fasttime merged 9 commits intoeslint:mainfrom Apr 10, 2025
Merged
Conversation
lumirlumir
changed the title
MarkdownRuleDefinitionIMarkdownSourceCode with MarkdownSourceCode in MarkdownRuleDefinition
|
Hi @lumirlumir!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
lumirlumir
changed the title
IMarkdownSourceCode with MarkdownSourceCode in MarkdownRuleDefinitionIMarkdownSourceCode with MarkdownSourceCode
fasttime
reviewed
Apr 5, 2025
Member
fasttime
left a comment
fasttime
left a comment
There was a problem hiding this comment.
There's a merge conflict now.
Member
Author
1 task
fasttime
reviewed
Apr 6, 2025
Member
fasttime
left a comment
fasttime
left a comment
There was a problem hiding this comment.
Note that there is a new merge conflict now in src/language/markdown-source-code.js.
Member
Author
fasttime
reviewed
Apr 8, 2025
1 task
fasttime
reviewed
Apr 9, 2025
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Merged
lumirlumir
deleted the
fix-update-type-reference-for-markdownruledefinition
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR addresses issue eslint/rewrite#175.
I also added
rollup-plugin-deleteto fix the build issues in CI. It's the same plugin used in JSON'srollup.config.js.Summary
When using
IMarkdownSourceCode, we don't have access to methods likegetParent,getAncestors,getText, andlines. To fix this, I replaced it withMarkdownSourceCode, which does provide those methods. This approach is already being used in the JSON plugin.Fixes
Fixes: eslint/rewrite#175.