Skip to content

Comments

Chore: Test multline autofix with CRLF#125

Closed
btmills wants to merge 1 commit intomainfrom
crlf
Closed

Chore: Test multline autofix with CRLF#125
btmills wants to merge 1 commit intomainfrom
crlf

Conversation

@btmills
Copy link
Member

@btmills btmills commented Oct 8, 2019

Originally discovered in #120

@btmills btmills closed this Nov 26, 2020
@btmills btmills deleted the branch main November 26, 2020 04:43
@btmills btmills reopened this Nov 26, 2020
@btmills btmills changed the base branch from master to main November 26, 2020 04:45
btmills added a commit that referenced this pull request May 20, 2021
Originally discovered in #120 and cherry-picked from #125.
btmills added a commit that referenced this pull request May 20, 2021
The previous parser, `remark-parse` v7, included a transitive dependency
on an npm package with a security vulnerability. Newer versions of
`remark-parse` are wrappers around a new underlying parser,
`mdast-util-from-markdown`, so we can use that directly.

The previous parser also failed to preserve `\r\n` line endings,
replacing them all with `\n`. The new parser correctly preserves `\r\n`
line endings, finally providing a fix for the failing test case I
cherry-picked in the previous commit. The improved behavior also
uncovered an incorrect line ending test assertion that this commit
corrects.

While this change is in theory fully compatible, containing just bug
fixes, I'm tagging it `Update:` in case there are compatibility changes
in the new parser. This is consistent with #175, which upgraded
`remark-parse` v5 to v7 in a semver-minor `Update:` change.
@btmills btmills closed this in 32203f6 May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant