Hi @mrmckeb!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

• The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
• There should be a space following the initial tag and colon, for example 'feat: Message'.
• The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

The committers listed above are authorized under a signed CLA.

• ✅ login: mrmckeb / name: Brody McKee (2d83d0d, 3e62558, caeffc7)

Thanks for the prompt review and feedback @nzakas. I'll wait for the response around exporting types this way, and then either rework this PR or update the tests.

Wanted to verify with everyone that we're okay with exporting types this way?

I'm fine with this approach. @fasttime what do you think?

I'm also fine with this approach. Note though that we need a separate export for CommonJS types, along the lines of:

"./types": {
  "require": {
    "types": "./dist/cjs/types.cts"
  },
  "import": {
    "types": "./dist/esm/types.d.ts"
  }
}

This is to avoid the TypeScript error Type-only import of an ECMAScript module from a CommonJS module must have a 'resolution-mode' attribute.

Thanks @mdjermanovic and @fasttime.

I've made those changes. I'd been working/testing in an ESM-only environment, so that was a good catch.