feat: Add JSONLanguage#visitorKeys#4
Conversation
Release-As: 0.1.0
|
|
||
| import { parse } from "@humanwhocodes/momoa"; | ||
| import { JSONSourceCode } from "./json-source-code.js"; | ||
| import { visitorKeys } from "@humanwhocodes/momoa"; |
There was a problem hiding this comment.
We should update the dependency to ^3.1.1 in package.json.
There was a problem hiding this comment.
This is so weird. I know I updated this locally and tested, and this is the second time you've pointed out that the version hasn't been updated in package.json. 🤔
There was a problem hiding this comment.
Actually, it is updated in package.json but for some reason git isn't included it in the branch.
There was a problem hiding this comment.
It works if 3.1.1 is locally installed, which in most cases would be the case after doing npm install since it's the latest in-range version, but to be sure it should be set in package.json.
|
When I tested this, it turned out that things for which this matters don't actually work (e.g., selectors like |
|
Ah interesting. Yeah, I don't think we can assume every AST type will have a |
For some reason, in this repo GitHub doesn't pull anything from the commits into the default commit body.
|
|
It's probably because we have this setting:
Was it intentional? In other repos, we have this:
|
|
Not intentional. Need to add that to the new repo template. |
|
Merging now as this change is correct for this package. I am working on fixing |
2 participants
Prerequisites checklist
What is the purpose of this pull request?
Added
JSONLanguage#visitorKeys.What changes did you make? (Give an overview)
JSONLanguage#visitorKeysJSONLanguage#visitorKeysis properly createdRelated Issues
Is there anything you'd like reviewers to focus on?
Please double check that the following line is included in the merge commit body to ensure we reset the package version number:
Release-As: 0.1.0