fix!: remove rollup, extraneous types and migrate to ESM-only#197
Merged
fix!: remove rollup, extraneous types and migrate to ESM-only#197
rollup, extraneous types and migrate to ESM-only#197Conversation
This was referenced Jan 1, 2026
Merged
1 task
lumirlumir
commented
Jan 2, 2026
| "npm run build:update-rules-docs" | ||
| ], | ||
| "{src/rules/*.js,tools/update-rules-docs.js}": [ | ||
| "{src/rules/*.js,tools/update-rules-docs.js,README.md}": [ |
Member
Author
There was a problem hiding this comment.
README.md pre-commit hook update can be consolidated into a single line, I went ahead. Just for a reference, the Markdown plugin also uses this approach:
There was a problem hiding this comment.
Pull request overview
This PR migrates the @eslint/json package from a dual CommonJS/ESM format to ESM-only, removing the Rollup bundler and associated build complexity. The migration simplifies the build process by eliminating workarounds previously needed to support both module formats.
Key changes:
- Replaced Rollup-based bundling with TypeScript compilation that emits both JavaScript and declaration files
- Simplified package.json exports to use a single ESM entry point instead of dual CJS/ESM conditional exports
- Updated all internal type imports from
.tsto.jsextensions to comply with ESM module resolution
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Simplified TypeScript configuration for ESM-only output, removing dual-format compilation settings and consolidating output to single dist/ directory |
| tsconfig.esm.json | Removed secondary TypeScript configuration file that was used for ESM-specific type generation |
| tools/dedupe-types.js | Removed script that deduped type imports after rollup bundling, no longer needed without rollup |
| tools/build-cts.js | Removed script that generated CommonJS type definitions (.cts files), no longer needed for ESM-only package |
| rollup.config.js | Removed Rollup configuration and bundler from build process |
| package.json | Updated exports to ESM-only format, simplified build scripts, added @arethetypeswrong/cli for type validation, removed rollup dependencies, consolidated lint-staged configuration |
| src/rules/*.js | Updated type imports from ../types.ts to ../types.js to follow ESM conventions |
| src/languages/json-source-code.js | Updated type import from ../types.ts to ../types.js |
| jsr.json | Updated export paths and simplified publish configuration to reference consolidated dist/ directory |
| .github/workflows/ci.yml | Added new CI job to validate type definitions using @arethetypeswrong/cli |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
In this PR, I've resolved the issue mentioned in #196, removing
rollupand extraneous types and migrating the package to ESM-only.The main focus of this PR is removing much of the logic and the workarounds we previously used to support a dual CommonJS/ESM package.
Some notable parts are as follows:
tsconfig.json: I mostly followed the convention used in the Markdown plugin, which is now an ESM-only package. (Ref: https://github.com/eslint/markdown/blob/main/tsconfig.json)package.json: Likewise, I mostly followed the convention used in the Markdown plugin. (Ref: https://github.com/eslint/markdown/blob/main/package.json).github/workflows/ci.yml: Added@arethetypeswrong/clito verify that type exports work correctly.What changes did you make? (Give an overview)
In this PR, I've resolved the issue mentioned in #196, removing
rollupand extraneous types and migrating the package to ESM-only.Related Issues
rollup, extraneous types and migrate to ESM-only css#352arethetypeswrongin CI markdown#598rollupand migrate to ESM-only as part of the upcoming v1.0.0 (JSON/CSS) #196Is there anything you'd like reviewers to focus on?
I didn't intentionally remove
tests/types/cjs-import.test.ctssincerequire(ESM)is now enabled. However, if removing it is the right course of action, I'm happy to do so.