-
-
Notifications
You must be signed in to change notification settings - Fork 74
feat: add Bluesky to social networks #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for new-eslint ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| "chat": "https://eslint.org/chat", | ||
| "bluesky": "https://bsky.app/profile/eslint.org", | ||
| "mastodon": "https://fosstodon.org/@eslint", | ||
| "twitter": "https://twitter.com/geteslint", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't resist putting the three social media networks together, in alphabetical order...
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
30187ef to
3a32bcc
Compare
| website: itemWebsite, | ||
| github: itemGitHub, | ||
| twitter: itemTwitter, | ||
| mastodon: itemMastodons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Existing typo fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, yes!
|
Only other thing we might want to add is a share button on the blog post template? |
nzakas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Prerequisites checklist
What is the purpose of this pull request?
Add Bluesky logos to the website alongside the existing Mastodon URLs and Twitter ones.
What changes did you make? (Give an overview)
bluesky_urls for authors I could find on BlueskyRelated Issues
Fixes #668.
Is there anything you'd like reviewers to focus on?