Skip to content

Conversation

@JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 6, 2024

Prerequisites checklist

What is the purpose of this pull request?

Add Bluesky logos to the website alongside the existing Mastodon URLs and Twitter ones.

What changes did you make? (Give an overview)

  • Added the Bluesky 🦋 logo in places that already have the Mastodon Ⓜ️ or Twitter/X ✖️
    • I couldn't resist moving the three together and putting them in alphabetical order: Bluesky, Mastodon, Twitter/X
  • Added the field to author data, and filled in bluesky_urls for authors I could find on Bluesky

Related Issues

Fixes #668.

Is there anything you'd like reviewers to focus on?

  • Are there logo placements I missed?
  • Are there Bluesky URLs of team members I missed?

@netlify
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit adb3bd5
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/67572e6435349c0009cc073c
😎 Deploy Preview https://deploy-preview-669--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit adb3bd5
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/67572e645fdf2f00088c0457
😎 Deploy Preview https://deploy-preview-669--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit adb3bd5
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/67572e64f000600008e90fc2
😎 Deploy Preview https://deploy-preview-669--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

"chat": "https://eslint.org/chat",
"bluesky": "https://bsky.app/profile/eslint.org",
"mastodon": "https://fosstodon.org/@eslint",
"twitter": "https://twitter.com/geteslint",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't resist putting the three social media networks together, in alphabetical order...

@netlify
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit adb3bd5
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/67572e64bd189100086fb3b3
😎 Deploy Preview https://deploy-preview-669--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit adb3bd5
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/67572e64491f3600084616d4
😎 Deploy Preview https://deploy-preview-669--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit adb3bd5
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/67572e64f57c510008f9b928
😎 Deploy Preview https://deploy-preview-669--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit adb3bd5
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/67572e646df1e60008aba905
😎 Deploy Preview https://deploy-preview-669--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit adb3bd5
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/67572e64bb38500008eb10f1
😎 Deploy Preview https://deploy-preview-669--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg force-pushed the bsky branch 2 times, most recently from 30187ef to 3a32bcc Compare December 6, 2024 13:55
website: itemWebsite,
github: itemGitHub,
twitter: itemTwitter,
mastodon: itemMastodons
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing typo fix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, yes!

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review December 6, 2024 15:37
@nzakas
Copy link
Member

nzakas commented Dec 6, 2024

Only other thing we might want to add is a share button on the blog post template?

https://docs.bsky.app/docs/advanced-guides/intent-links

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 0f798b8 into eslint:main Dec 9, 2024
37 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the bsky branch December 9, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Suggestion: Add Bluesky handles alongside Mastodon and Twitter/X

3 participants