Skip to content

New: Option to use yarn in init wizard (#9863)#9864

Closed
maciej-ka wants to merge 1 commit into
eslint:masterfrom
maciej-ka:option-to-use-yarn-in-init-wizard
Closed

New: Option to use yarn in init wizard (#9863)#9864
maciej-ka wants to merge 1 commit into
eslint:masterfrom
maciej-ka:option-to-use-yarn-in-init-wizard

Conversation

@maciej-ka

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[x] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
PR adds a new option and passes it to a place where at the moment npm i is always invoked.

Is there anything you'd like reviewers to focus on?
Perhaps there is an easier way to pass CLI option from bin/eslint.js to util/npm-util.js. (Potentially util/npm-util.js could read process.args on its own but that didn't feel right).

@jsf-clabot

jsf-clabot commented Jan 19, 2018

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@maciej-ka

Copy link
Copy Markdown
Contributor Author

Having this would save some trouble in create-react-app when calling react-scripts lint --init.

@maciej-ka maciej-ka changed the title feat: option to use yarn in init wizard #9863 Feat: option to use yarn in init wizard #9863 Jan 20, 2018
@maciej-ka maciej-ka changed the title Feat: option to use yarn in init wizard #9863 New: option to use yarn in init wizard #9863 Jan 20, 2018
@maciej-ka maciej-ka changed the title New: option to use yarn in init wizard #9863 New: Option to use yarn in init wizard #9863 Jan 20, 2018
@maciej-ka maciej-ka force-pushed the option-to-use-yarn-in-init-wizard branch from db72c1d to b77e2d9 Compare January 20, 2018 11:34
@maciej-ka maciej-ka changed the title New: Option to use yarn in init wizard #9863 New: Option to use yarn in init wizard (#9863) Jan 20, 2018
@maciej-ka maciej-ka force-pushed the option-to-use-yarn-in-init-wizard branch from b77e2d9 to 1edf60f Compare January 20, 2018 11:39
@not-an-aardvark

Copy link
Copy Markdown
Member

Closing this PR because #9863 has also been closed. Thanks for the contribution!

@eslint-deprecated eslint-deprecated Bot locked and limited conversation to collaborators Jul 22, 2018
@eslint-deprecated eslint-deprecated Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

archived due to age This issue has been archived; please open a new issue for any further discussion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants