feat: Implement api support for bulk-suppressions by adf0nt3s · Pull Request #20565 · eslint/eslint

adf0nt3s · 2026-02-26T04:05:24Z

Prerequisites checklist

I have read the contributing guidelines.

AI acknowledgment

I did not use AI to generate this PR.
(If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: bulk suppression support for the Eslint API

What changes did you make? (Give an overview)

This implements API support for bulk suppressions, as outlined here eslint/rfcs#142

fixes #19603

Is there anything you'd like reviewers to focus on?

netlify · 2026-02-26T04:05:30Z

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	`74449e6`
🔍 Latest deploy log	https://app.netlify.com/projects/docs-eslint/deploys/69b579d141d347000899bb41

eslint-github-bot · 2026-02-26T04:05:32Z

Hi @adf0nt3s!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
There should be a space following the initial tag and colon, for example 'feat: Message'.
The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

docs/src/use/suppressions.md

lib/eslint/eslint.js

eslint-github-bot · 2026-02-26T04:40:59Z

Hi @adf0nt3s!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
There should be a space following the initial tag and colon, for example 'feat: Message'.
The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

eslint-github-bot · 2026-02-26T04:41:02Z

Hi @adf0nt3s!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
There should be a space following the initial tag and colon, for example 'feat: Message'.
The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

eslint-github-bot · 2026-02-26T04:41:37Z

Hi @adf0nt3s!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
There should be a space following the initial tag and colon, for example 'feat: Message'.
The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

fasttime

Thanks for the pull request. I left some suggestions.

lib/eslint/eslint-helpers.js

docs/src/integrate/nodejs-api.md

lib/eslint/eslint-helpers.js

adf0nt3s · 2026-03-06T02:16:02Z

The note about circular deps aside, i've implemented the feedback 👍

lib/eslint/eslint.js

docs/src/use/suppressions.md

lib/eslint/eslint.js

lib/eslint/eslint-helpers.js

lib/shared/message-counts.js

fasttime

It would be good to have a test where suppressionsLocation is set to an absolute path.

tests/lib/eslint/eslint.js

lib/types/index.d.ts

tests/lib/eslint/eslint.js

adf0nt3s · 2026-03-13T04:50:41Z

tests/lib/eslint/eslint.js

+				);
+			} finally {
+				// Clean up cache file
+				fs.rmSync(cacheLocation, { force: true });


Not sure about this, let me know if there is a better optoin

If we move this unit test into the testCacheWithConcurrency function, where the other cache-related tests are, then we can set cacheFilePath to some temporary directory, for example:

eslint/tests/lib/eslint/eslint.js

Line 13275 in a176319

cacheFilePath = getFixturePath(".eslintcache");

and use that directory as a cacheLocation in the ESLint options. And then, when the test finishes, cacheLocation will be deleted automatically.

eslint/tests/lib/eslint/eslint.js

Lines 12878 to 12883 in a176319

afterEach(() => {

sinon.restore();

if (cacheFilePath) {

doDelete(cacheFilePath);

}

});

Note: unit tests inside testCacheWithConcurrency should also pass the concurrency option, which is useful to test the cache handling in separate parts of the code.

fasttime · 2026-03-14T10:19:43Z

tests/lib/eslint/eslint.js

+				);
+			} finally {
+				// Clean up cache file
+				fs.rmSync(cacheLocation, { force: true });


If we move this unit test into the testCacheWithConcurrency function, where the other cache-related tests are, then we can set cacheFilePath to some temporary directory, for example:

eslint/tests/lib/eslint/eslint.js

Line 13275 in a176319

cacheFilePath = getFixturePath(".eslintcache");

and use that directory as a cacheLocation in the ESLint options. And then, when the test finishes, cacheLocation will be deleted automatically.

eslint/tests/lib/eslint/eslint.js

Lines 12878 to 12883 in a176319

afterEach(() => {

sinon.restore();

if (cacheFilePath) {

doDelete(cacheFilePath);

}

});

Note: unit tests inside testCacheWithConcurrency should also pass the concurrency option, which is useful to test the cache handling in separate parts of the code.

lib/types/index.d.ts

Co-authored-by: Francesco Trotta <[email protected]>

fasttime

LGTM, thanks! Leaving open for another review.

mdjermanovic

LGTM, thanks!

adf0nt3s · 2026-03-16T20:14:26Z

Excellent, thanks friends!

github-project-automation bot added this to Triage Feb 26, 2026

github-project-automation bot moved this to Needs Triage in Triage Feb 26, 2026

github-actions bot added cli Relates to ESLint's command-line interface core Relates to ESLint's core APIs and features labels Feb 26, 2026

adf0nt3s commented Feb 26, 2026

View reviewed changes

docs/src/use/suppressions.md Show resolved Hide resolved

adf0nt3s commented Feb 26, 2026

View reviewed changes

lib/eslint/eslint.js Outdated Show resolved Hide resolved

adf0nt3s changed the title ~~[draft] Implement api support for bulk-suppressions~~ feat: Implement api support for bulk-suppressions Feb 26, 2026

eslint-github-bot bot added the feature This change adds a new feature to ESLint label Feb 26, 2026

adf0nt3s force-pushed the feat/implement-api-suppressions branch 2 times, most recently from 041fb41 to 9aa94f6 Compare February 26, 2026 04:49

adf0nt3s marked this pull request as ready for review February 26, 2026 04:58

adf0nt3s requested a review from a team as a code owner February 26, 2026 04:58

adf0nt3s mentioned this pull request Feb 26, 2026

feat: Consider bulk suppressions via the Node.js API eslint/rfcs#142

Merged

eslint-github-bot bot mentioned this pull request Feb 26, 2026

Change Request: Support bulk suppression in Node.js API #19603

Closed

1 task

fasttime moved this from Needs Triage to Triaging in Triage Mar 2, 2026

fasttime added the accepted There is consensus among the team that this change meets the criteria for inclusion label Mar 2, 2026

fasttime moved this from Triaging to Implementing in Triage Mar 2, 2026

fasttime reviewed Mar 2, 2026

View reviewed changes

lib/eslint/eslint-helpers.js Outdated Show resolved Hide resolved

docs/src/integrate/nodejs-api.md Outdated Show resolved Hide resolved

lib/eslint/eslint-helpers.js Outdated Show resolved Hide resolved

fasttime added the contributor pool label Mar 2, 2026

fasttime reviewed Mar 10, 2026

View reviewed changes

fasttime reviewed Mar 12, 2026

View reviewed changes

lib/shared/message-counts.js Outdated Show resolved Hide resolved

fasttime reviewed Mar 12, 2026

View reviewed changes

tests/lib/eslint/eslint.js Show resolved Hide resolved

lib/types/index.d.ts Outdated Show resolved Hide resolved

fasttime reviewed Mar 12, 2026

View reviewed changes

tests/lib/eslint/eslint.js Show resolved Hide resolved

adf0nt3s force-pushed the feat/implement-api-suppressions branch from b9dadea to 4c0367c Compare March 13, 2026 00:07

adf0nt3s force-pushed the feat/implement-api-suppressions branch from 4c0367c to b6379b9 Compare March 13, 2026 00:12

adf0nt3s commented Mar 13, 2026

View reviewed changes

fasttime reviewed Mar 14, 2026

View reviewed changes

adf0nt3s and others added 7 commits March 14, 2026 10:07

feat: implement api support for bulk-suppressions

af8d169

Implement PR feedback

a7c9b7d

Assume normalized options

bb88ca8

Co-authored-by: Francesco Trotta <[email protected]>

Assume normalized options

73084e2

Co-authored-by: Francesco Trotta <[email protected]>

Implement PR feedback

0b3744c

Additional feedback

78813c9

Correct test placement

74449e6

adf0nt3s force-pushed the feat/implement-api-suppressions branch from 8c2bfd2 to 74449e6 Compare March 14, 2026 15:07

fasttime approved these changes Mar 16, 2026

View reviewed changes

fasttime moved this from Implementing to Second Review Needed in Triage Mar 16, 2026

mdjermanovic approved these changes Mar 16, 2026

View reviewed changes

mdjermanovic merged commit 0916995 into eslint:main Mar 16, 2026
42 checks passed

github-project-automation bot moved this from Second Review Needed to Complete in Triage Mar 16, 2026

wagenet mentioned this pull request Mar 17, 2026

feat: surface bulk-suppressed ESLint violations as configurable diagnostics microsoft/vscode-eslint#2139

Open

5 tasks

G-Rath mentioned this pull request Mar 26, 2026

Change Request: ability to have --fix respect suppressions #20062

Open

1 task

	afterEach(() => {
	sinon.restore();
	if (cacheFilePath) {
	doDelete(cacheFilePath);
	}
	});

Uh oh!

Conversation

adf0nt3s commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Prerequisites checklist

AI acknowledgment

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Uh oh!

netlify bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for docs-eslint canceled.

Uh oh!

eslint-github-bot bot commented Feb 26, 2026

Uh oh!

Uh oh!

Uh oh!

eslint-github-bot bot commented Feb 26, 2026

Uh oh!

eslint-github-bot bot commented Feb 26, 2026

Uh oh!

eslint-github-bot bot commented Feb 26, 2026

Uh oh!

fasttime left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adf0nt3s commented Mar 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fasttime left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adf0nt3s Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

fasttime Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

adf0nt3s Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

fasttime Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fasttime left a comment

Choose a reason for hiding this comment

Uh oh!

mdjermanovic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adf0nt3s commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

adf0nt3s commented Feb 26, 2026 •

edited

Loading

netlify bot commented Feb 26, 2026 •

edited

Loading