refactor: simplify isCombiningCharacter helper#20524
Merged
fasttime merged 2 commits intoeslint:mainfrom Mar 6, 2026
Merged
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
lumirlumir
approved these changes
Feb 20, 2026
Member
lumirlumir
left a comment
lumirlumir
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Would like one more check from the team before merging.
lumirlumir
added
the
accepted
snitin315
reviewed
Feb 21, 2026
| module.exports = function isCombiningCharacter(codePoint) { | ||
| return /^[\p{Mc}\p{Me}\p{Mn}]$/u.test(String.fromCodePoint(codePoint)); | ||
| return /^\p{M}$/u.test(String.fromCodePoint(codePoint)); | ||
| }; |
Contributor
There was a problem hiding this comment.
I've also updated this helper in #20396, does that change make sense or will this regexp be better?
Contributor
Author
There was a problem hiding this comment.
This regexp still contains property escape, so it won't work with the icu-less Node.js build. If the goal is compatibility with such build, then of course #20396 so be pursued.
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Refactor
What changes did you make? (Give an overview)
Per D52 Combing Character in the chapter 3 of the Unicode core, and PropertyValueAlias.txt on UCD
The General Category M consists of exactly three sub categories: Mc, Me, and Mn, therefore the regex here can be simplified.
Is there anything you'd like reviewers to focus on?