fix: update error message for unused suppressions#20496
Merged
mdjermanovic merged 4 commits intoeslint:mainfrom Feb 13, 2026
Merged
fix: update error message for unused suppressions#20496mdjermanovic merged 4 commits intoeslint:mainfrom
mdjermanovic merged 4 commits intoeslint:mainfrom
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
1 task
mdjermanovic
added
the
accepted
mdjermanovic
changed the title
Member
mdjermanovic
left a comment
mdjermanovic
left a comment
There was a problem hiding this comment.
I think a single line message is fine, just left a suggestion to reword it a bit.
mdjermanovic
changed the title
Co-authored-by: Milos Djermanovic <[email protected]>
lib/cli.js
Outdated
| if (unusedSuppressionsCount > 0) { | ||
| log.error( | ||
| "There are suppressions left that do not occur anymore. Consider re-running the command with `--prune-suppressions`.", | ||
| "There are suppressions left that do not occur anymore. To resolve this, re-run the command with `--prune-suggestions` to remove unused suppressions. To ignore unused suppressions, use `--pass-on-unpruned-suppressions`.", |
Member
There was a problem hiding this comment.
Suggested change
| "There are suppressions left that do not occur anymore. To resolve this, re-run the command with `--prune-suggestions` to remove unused suppressions. To ignore unused suppressions, use `--pass-on-unpruned-suppressions`.", | |
| "There are suppressions left that do not occur anymore. To resolve this, re-run the command with `--prune-suppressions` to remove unused suppressions. To ignore unused suppressions, use `--pass-on-unpruned-suppressions`.", |
Typo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Update the message of the CLI when there are excess suppressions.
Now it also mentions the flag
--pass-on-unpruned-suggestions.Fixes #20490.
Is there anything you'd like reviewers to focus on?
Should the message be multiline, for example: