Conversation
✅ Deploy Preview for docs-eslint canceled.
|
mdjermanovic
added
the
accepted
|
suggestion: Revert #20304 chore: ignore prettier updates in renovate to keep in sync with trunk |
To add more context: version pinning for the |
aladdin-add
left a comment
aladdin-add
left a comment
There was a problem hiding this comment.
I don't think it needs to be 100% consistent with existing features. The important thing is to keep the functionality that existed before the trunk was introduced. You can refer to: #18643.
Many additional features (such as Go-based tools) don't seem worth the extra maintenance burden they would add.
|
@aladdin-add Yeah, that was my original approach, just keeping the pre-trunk functionality. I only added Since opinions seem split, maybe we should get a TSC decision on whether we actually want to keep it. |
|
I think it would be fine to just restore checks we had before introducing Trunk, plus add the Prettier check because we have since switched to Prettier for formatting in this repo. If there are more checks we'd like to add, we could discuss them later. That said, actionlint seems useful and the way it is enabled in this PR looks fairly simple, so I'd be in favor of keeping it as well. @eslint/eslint-tsc thoughts? |
mdjermanovic
added
the
tsc waiting
| - uses: actions/setup-go@v6 | ||
| with: | ||
| go-version: "stable" | ||
| - uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: "lts/*" | ||
|
|
||
| - name: Lint GitHub Actions workflows | ||
| run: | | ||
| go install github.com/rhysd/actionlint/cmd/[email protected] | ||
| actionlint -color -shellcheck= -pyflakes= | ||
|
|
There was a problem hiding this comment.
For reference, this is all that enables the actionlint check.
Sounds good 👍 |
mdjermanovic
removed
the
tsc waiting
lumirlumir
left a comment
lumirlumir
left a comment
There was a problem hiding this comment.
There is now a merge conflict.
| ## View the Tutorial Code | ||
|
|
||
| You can view the annotated source code for the tutorial [here](https://github.com/eslint/eslint/tree/main/docs/_examples/custom-rule-tutorial-code). | ||
| You can view the [annotated source code for the tutorial](https://github.com/eslint/eslint/tree/main/docs/_examples/custom-rule-tutorial-code). |
There was a problem hiding this comment.
Is this because of a lint rule?
package.json
Outdated
| "markdownlint-cli2 --fix", | ||
| "prettier --write" | ||
| ], | ||
| "!({**/*.js,**/*.json,**/*.jsonc,**/*.json5,**/*.yml,**/*.yaml,docs/src/**/*.md})": "prettier --write --ignore-unknown", |
There was a problem hiding this comment.
| "!({**/*.js,**/*.json,**/*.jsonc,**/*.json5,**/*.yml,**/*.yaml,docs/src/**/*.md})": "prettier --write --ignore-unknown", | |
| "!({{*.,**/*.}{js,json,jsonc,json5,yml,yaml},docs/src/**/*.md})": "prettier --write --ignore-unknown", |
For some reason, patterns like *.json here match only at the root level while patterns like **/*.json here match everywhere except at the root level. I think this should do the work (exclude files for which we are already running prettier so that it doesn't run twice) but please doublecheck.
There was a problem hiding this comment.
I checked the lint-staged docs and it confirms that once a pattern contains a /, it matches paths instead of using matchBase, which explains the root vs nested behavior. I also tested the updated pattern and it works as expected 👍.
mdjermanovic
left a comment
mdjermanovic
left a comment
There was a problem hiding this comment.
LGTM, thanks! I've verified that all review comments have been addressed.
8 participants
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
What changes did you make? (Give an overview)
Removed Trunk and its associated configuration, restoring direct control over linting and formatting via ESLint and Prettier.
As part of this change, I’ve also updated some markdown files to comply with the new MD059 rule introduced in
[email protected]. If anyone prefers to disable the rule instead, please let me know, and I can revisit this.Fixes #20470
Is there anything you'd like reviewers to focus on?