Skip to content

Conversation

@lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Dec 10, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

In this PR, I've created the package-manager test workflow as part of the effort to centralize workflows (ref: eslint/workflows#4).

Detailed context is in eslint/workflows#25, and the full workflow file is available at https://github.com/eslint/workflows/blob/main/.github/workflows/ci-package-manager.yml.

To summarize, this workflow packs the eslint package with npm pack and tests whether it is installable with various package managers, including npm, yarn v1, yarn, pnpm, and bun.

Is there anything you'd like reviewers to focus on?

Refs: eslint/workflows#25, eslint/workflows#4

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Dec 10, 2025
@netlify
Copy link

netlify bot commented Dec 10, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 6f4e2e6
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/6939240b3433cc00080f1f91

@eslint-github-bot

This comment was marked as resolved.

@eslint-github-bot

This comment was marked as resolved.

@lumirlumir lumirlumir changed the title Ci centralize package manager test ci: centralize package manager test Dec 10, 2025
@eslint-github-bot eslint-github-bot bot added the build This change relates to ESLint's build process label Dec 10, 2025
@lumirlumir lumirlumir changed the title ci: centralize package manager test ci: create package manager test Dec 10, 2025
@lumirlumir lumirlumir marked this pull request as ready for review December 10, 2025 07:43
@lumirlumir lumirlumir requested a review from a team as a code owner December 10, 2025 07:43
Copilot AI review requested due to automatic review settings December 10, 2025 07:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new CI workflow job to test ESLint package installation across multiple package managers (npm, yarn v1, yarn, pnpm, and bun), as part of the effort to centralize workflows in the eslint/workflows repository.

Key Changes:

  • Adds test_package_manager job that calls a reusable workflow from the centralized eslint/workflows repository

@aladdin-add aladdin-add merged commit 54bf0a3 into main Dec 11, 2025
43 checks passed
@aladdin-add aladdin-add deleted the ci-centralize-package-manager-test branch December 11, 2025 09:07
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build This change relates to ESLint's build process github actions

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants