Skip to content

Conversation

@fasttime
Copy link
Member

@fasttime fasttime commented Dec 8, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Fix the build.

What changes did you make? (Give an overview)

This PR updates the knip config to ignore scss files under docs/src/assets/scss. The latest knip version 5.72.0 has started to recognize these files as unused and is reporting a problem. For example:

https://github.com/eslint/eslint/actions/runs/20035955594/job/57457417964

I've also added bin to the project directories.

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Dec 8, 2025
@eslint-github-bot eslint-github-bot bot added the build This change relates to ESLint's build process label Dec 8, 2025
@netlify
Copy link

netlify bot commented Dec 8, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit ea85c53
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/6937323b53dfdd0008e3a42b

@webpro
Copy link
Contributor

webpro commented Dec 8, 2025

Suggestion:

{
  "docs": {
    "entry": ["src/assets/scss/{styles,print}.scss"]
  }
}

or just ignore as you're doing and forget about it 👍

@fasttime fasttime marked this pull request as ready for review December 8, 2025 20:13
@fasttime fasttime requested a review from a team as a code owner December 8, 2025 20:13
@fasttime fasttime changed the title build: ignore scss assets in knip build: add .scss files entry to knip Dec 8, 2025
@ntnyq ntnyq mentioned this pull request Dec 9, 2025
1 task
@aladdin-add aladdin-add moved this from Needs Triage to Merge Candidates in Triage Dec 9, 2025
@aladdin-add aladdin-add merged commit a126a2a into main Dec 9, 2025
31 checks passed
@aladdin-add aladdin-add deleted the fix-for-knip-v5.72 branch December 9, 2025 06:56
@github-project-automation github-project-automation bot moved this from Merge Candidates to Complete in Triage Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build This change relates to ESLint's build process

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

4 participants