Skip to content

Conversation

@mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Refs #20331

What changes did you make? (Give an overview)

Removes Examples heading from several rule docs that still have it and disallows adding this heading (by node Makefile.js checkRuleFiles check).

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic requested a review from a team as a code owner December 1, 2025 16:51
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Dec 1, 2025
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Dec 1, 2025
@netlify
Copy link

netlify bot commented Dec 1, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 5b93a51
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/692dc790ce04740007475205
😎 Deploy Preview https://deploy-preview-20364--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@amareshsm amareshsm added the accepted There is consensus among the team that this change meets the criteria for inclusion label Dec 1, 2025
Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Need one more approval.

@amareshsm amareshsm moved this from Needs Triage to Merge Candidates in Triage Dec 1, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lumirlumir lumirlumir merged commit 9e5a5c2 into main Dec 2, 2025
32 checks passed
@lumirlumir lumirlumir deleted the docs-disallow-examples-heading branch December 2, 2025 03:54
@github-project-automation github-project-automation bot moved this from Merge Candidates to Complete in Triage Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

4 participants