Skip to content

Conversation

@Pixel998
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

  • Simplified the looksLikeExport function by removing unused export types that cannot wrap class/function declarations
  • Removed the redundant isCommentToken check since we directly validate the token type
  • Extracted the nested findJSDocComment function to make the logic more readable.

Is there anything you'd like reviewers to focus on?

@Pixel998 Pixel998 requested a review from a team as a code owner November 30, 2025 17:38
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Nov 30, 2025
@netlify
Copy link

netlify bot commented Nov 30, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 67f25da
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/692efe9031d22600084259ee
😎 Deploy Preview https://deploy-preview-20360--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Nov 30, 2025
@github-actions github-actions bot added the rule Relates to ESLint's core rules label Nov 30, 2025
@nzakas nzakas moved this from Needs Triage to Implementing in Triage Dec 1, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 3115021 into main Dec 2, 2025
31 checks passed
@mdjermanovic mdjermanovic deleted the refactor/simplify-jsdoc-detection branch December 2, 2025 16:12
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore This change is not user-facing rule Relates to ESLint's core rules

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants