fix: strict removed formatters check #20241
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the formatter loading logic by adding a stricter check for the removed formatters error message. Previously, the removed formatter message was shown for any error when the formatter name was in the removed list. Now, it only shows this message when the error code is specifically ERR_MODULE_NOT_FOUND, preventing incorrect error messages for other types of errors (like syntax errors in the formatter file).
github-actions
bot
added
cli
aladdin-add
added
the
accepted
aladdin-add
left a comment
aladdin-add
left a comment
There was a problem hiding this comment.
There is also this check in cli-engine, but it is about to be removed, so there is no need to change it.
LGTM, thanks! Would like another review before merging.
|
The original issue is already assigned to @githrdw. Per our policies, we should wait for the assignee to submit a PR. |
Sorry, I didn't notice that the issue has been assigned to the poster. Should we keep this PR open and wait for the issue poster or should I close this immediately? |
|
@ntnyq I've left a comment on #20240 (comment). Let's wait a bit for the original authors to reply :) |
|
It seems there hasn't been a reply from the original author in over two weeks. I am wondering what's the policy here. Should we proceed with this one, or wait a bit longer? |
|
Sorry, I was not aware that I assigned myself to the issue and I cannot remove myself from it :( |
|
@ntnyq Are you still working on this issue? If yes, can you implement this suggestion #20241 (comment) |
|
@ntnyq you can continue working on this PR, but in the future please follow our contributor guidelines and claim the issue first. |
ntnyq
force-pushed
the
fix/load-formatter
branch
2 times, most recently
from
892e7fd to
1b45510
Compare
mdjermanovic
left a comment
mdjermanovic
left a comment
There was a problem hiding this comment.
Just a reminder that #20241 (comment) hasn't been addressed yet.
Thanks for your advice. I was working over the weekend and just resolved the feedback. |
|
CI failed for knip check, #20389 is fixing it. |
ntnyq
force-pushed
the
fix/load-formatter
branch
from
7d74bb7 to
5fffde9
Compare
ntnyq
force-pushed
the
fix/load-formatter
branch
from
5fffde9 to
fa2f9f7
Compare
6 participants
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Fixes #20240
What changes did you make? (Give an overview)
This PR adds a check to make it only reporting the removed formatter message when the error code equals to
ERR_MODULE_NOT_FOUND.Is there anything you'd like reviewers to focus on?