Skip to content

Conversation

@lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Dec 6, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Hello, I've added a missing <h2> tag (represented as ##) to prefer-spread.md.

While Known Limitations is represented as an <h2> tag throughout eslint.org, this instance was not marked with ##. So, I added it.

image

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Dec 6, 2024
@netlify
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 245e6ee
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/67530ae4429b8b000826bb2e
😎 Deploy Preview https://deploy-preview-19224--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lumirlumir lumirlumir marked this pull request as ready for review December 6, 2024 14:32
@lumirlumir lumirlumir requested a review from a team as a code owner December 6, 2024 14:32
@mdjermanovic mdjermanovic changed the title docs: add missing <h2>(##) to prefer-spread docs: add missing header to prefer-spread Dec 6, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit ba098bd into eslint:main Dec 6, 2024
27 checks passed
@lumirlumir lumirlumir deleted the docs-add-missing-h2-tag-to-prefer-spread branch December 6, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Relates to ESLint's documentation

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants