Skip to content

chore: update dependency mocha to ^10.7.3#18945

Merged
nzakas merged 1 commit intomainfrom
mocha-10
Sep 24, 2024
Merged

chore: update dependency mocha to ^10.7.3#18945
nzakas merged 1 commit intomainfrom
mocha-10

Conversation

@mdjermanovic
Copy link
Copy Markdown
Member

@mdjermanovic mdjermanovic commented Sep 24, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Recently released @wdio/browser-runner v9.1.0 added peer dependency to mocha@10.

This breaks npm install in this project:

Run npm install
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: [email protected]
npm error Found: mocha@8.[4](https://github.com/eslint/eslint/actions/runs/11009645923/job/30573261319#step:4:5).0
npm error node_modules/mocha
npm error   dev mocha@"^8.3.2" from the root project
npm error
npm error Could not resolve dependency:
npm error peer mocha@"^10.7.3" from @wdio/[email protected]
npm error node_modules/@wdio/browser-runner
npm error   dev @wdio/browser-runner@"^9.0.[5](https://github.com/eslint/eslint/actions/runs/11009645923/job/30573261319#step:4:6)" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error

https://github.com/eslint/eslint/actions/runs/11009645923/job/30573261319

What changes did you make? (Give an overview)

Updated dev dependency mocha to v10.

Is there anything you'd like reviewers to focus on?

Doublecheck if there are any breaking changes that affect us in either v9.0.0 or v10.0.0

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nzakas nzakas nzakas approved these changes

Assignees

No one assigned

Labels

chore This change is not user-facing

Projects

Triage
Status: Complete

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mdjermanovic @voxpelli @CAM-Gerlach @nzakas