refactor: don't use parent property in NodeEventGenerator#18653
Merged
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Refs #16999, eslint/json#4 (comment)
With the current version of ESLint, selectors like
Element > StringorElement + Elementdon't work with the@eslint/jsonlanguage plugin as ESLint passes an empty ancestry to esquery because the calculations inNodeEventGeneratorare based on theparentproperty of nodes, but JSON AST nodes don't have this property.What changes did you make? (Give an overview)
Refactored
NodeEventGeneratorto not use theparentproperty of nodes because language plugins are not required to produce this property in AST.The code change is that, instead of adding node's parent to the ancestry when entering the node,
enterNodenow adds the node itself to the ancestry for subsequent calls ofenterNodefor the node's subtree.Is there anything you'd like reviewers to focus on?