fix: no-unused-vars include caught errors pattern in report message#18609
Merged
snitin315 merged 2 commits intoeslint:mainfrom Jun 21, 2024
Merged
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
kirkwaiblinger
force-pushed
the
caught-errors-for-written-but-not-read
branch
from
17eefe0 to
cd59b01
Compare
Member
|
#18608 has been merged now, but it caused merge conflicts here. |
mdjermanovic
added
accepted
kirkwaiblinger
force-pushed
the
caught-errors-for-written-but-not-read
branch
from
cd59b01 to
d23dc2e
Compare
Contributor
Author
|
@mdjermanovic updated 👍 |
mdjermanovic
approved these changes
Jun 20, 2024
Member
mdjermanovic
left a comment
mdjermanovic
left a comment
There was a problem hiding this comment.
LGTM, thanks! Leaving open for one day in case anyone else would like to take a look.
mdjermanovic
changed the title
no-unused-vars include caught errors pattern in report message
snitin315
approved these changes
Jun 21, 2024
1 task
6 tasks
This was referenced Jul 19, 2024
This was referenced Aug 19, 2024
This was referenced Sep 3, 2024
This was referenced Sep 14, 2024
This was referenced Sep 23, 2024
This was referenced Sep 29, 2024
eslint-github-bot
Bot
added
the
archived due to age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
fix #18607
What changes did you make? (Give an overview)
Extracted report description inference to a common helper to reduce errors.
Depends on/blocked by #18608
Is there anything you'd like reviewers to focus on?