Skip to content

feat: no-useless-backreference support v flag#17408

Merged
mdjermanovic merged 2 commits intoeslint:mainfrom
ota-meshi:no-useless-backreference
Jul 25, 2023
Merged

feat: no-useless-backreference support v flag#17408
mdjermanovic merged 2 commits intoeslint:mainfrom
ota-meshi:no-useless-backreference

Conversation

@ota-meshi
Copy link
Copy Markdown
Member

@ota-meshi ota-meshi commented Jul 23, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Changes an existing rule (template)

What changes did you make? (Give an overview)

Refs #17223

This PR modifies the no-useless-backreference rule and adds support for regexp v flag.

Is there anything you'd like reviewers to focus on?

@ota-meshi ota-meshi requested a review from a team as a code owner July 23, 2023 05:44
@eslint-github-bot eslint-github-bot Bot added the feature This change adds a new feature to ESLint label Jul 23, 2023
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 23, 2023 •
edited
Loading

✅ Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 6a6de10
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/64bcc2c9fe30350008b7eca5

@mdjermanovic mdjermanovic mentioned this pull request Jul 23, 2023
Closed
19 tasks
@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion new syntax This issue is related to new syntax that has reached stage 4 contributor pool labels Jul 23, 2023
mdjermanovic
mdjermanovic approved these changes Jul 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Merging this should wait for #17404 to be merged first.

@mdjermanovic mdjermanovic added the rule Relates to ESLint's core rules label Jul 23, 2023
nzakas
nzakas approved these changes Jul 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@nzakas nzakas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Didn't merge because #17404 hasn't been approved for merge yet.

@mdjermanovic mdjermanovic merged commit a6a3ad4 into eslint:main Jul 25, 2023
@ota-meshi ota-meshi deleted the no-useless-backreference branch July 25, 2023 09:58
@eslint-github-bot eslint-github-bot Bot locked and limited conversation to collaborators Jan 22, 2024
@eslint-github-bot eslint-github-bot Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nzakas nzakas nzakas approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees

No one assigned

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion contributor pool feature This change adds a new feature to ESLint new syntax This issue is related to new syntax that has reached stage 4 rule Relates to ESLint's core rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ota-meshi @nzakas @mdjermanovic