docs: Fixed typos in `semi.md` by alundiak · Pull Request #17012 · eslint/eslint

alundiak · 2023-03-22T08:26:15Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

linux-foundation-easycla · 2023-03-22T08:26:20Z

The committers listed above are authorized under a signed CLA.

✅ login: alundiak / name: Andrii Lundiak (6a72a12)

netlify · 2023-03-22T08:26:23Z

✅ Deploy Preview for docs-eslint ready!

Name	Link
🔨 Latest commit	`6a72a12`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/641abba99e728000080e713e
😎 Deploy Preview	https://deploy-preview-17012--docs-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mdjermanovic · 2023-03-22T09:05:07Z


 * `"always"` (default) requires semicolons at the end of statements
-* `"never"` disallows semicolons as the end of statements (except to disambiguate statements beginning with `[`, `(`, `/`, `+`, or `-`)
+* `"never"` disallows semicolons at the end of statements (except to disambiguate statements beginning with `[`, `(`, `/`, `+`, or `-`)


I'm not sure if this was a typo. With "as", this means that the rule disallows semicolons that represent the end of a statement, which sounds right. Curious what others think about this.

I compared with other existed statements in this file, and as for me it resembles the same goal (as it's majority).

requires semicolons at the end of statements

requires semicolons at the end of statements if the next line starts with ...

ignores semicolons (or lacking semicolon) at the end of statements if the next line starts with ...

If as used then the English statement is NOT fully grammatically correctly ending.

But, if at usage is wrong, then I would need someone from maintainers to tell me so, coz at used more frequent.

at is a sign of position (in the statement), and it's OK as for me.

as sounds also kinda correct but in weirdly descriptive matter.

To me, both as and at sound okay here. Considering that "at the end" is used in the rest of the file without exceptions, I tend to believe that this was indeed an oversight.

Okay, let's switch to "at" for consistency.

mdjermanovic

LGTM, thanks!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.36.0` -> `8.37.0`](https://renovatebot.com/diffs/npm/eslint/8.36.0/8.37.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.37.0`](https://github.com/eslint/eslint/releases/tag/v8.37.0) [Compare Source](eslint/eslint@v8.36.0...v8.37.0) #### Features - [`b6ab8b2`](eslint/eslint@b6ab8b2) feat: `require-unicode-regexp` add suggestions ([#17007](eslint/eslint#17007)) (Josh Goldberg) - [`10022b1`](eslint/eslint@10022b1) feat: Copy getScope() to SourceCode ([#17004](eslint/eslint#17004)) (Nicholas C. Zakas) - [`1665c02`](eslint/eslint@1665c02) feat: Use plugin metadata for flat config serialization ([#16992](eslint/eslint#16992)) (Nicholas C. Zakas) - [`b3634f6`](eslint/eslint@b3634f6) feat: docs license ([#17010](eslint/eslint#17010)) (Samuel Roldan) - [`892e6e5`](eslint/eslint@892e6e5) feat: languageOptions.parser must be an object. ([#16985](eslint/eslint#16985)) (Nicholas C. Zakas) #### Bug Fixes - [`619f3fd`](eslint/eslint@619f3fd) fix: correctly handle `null` default config in `RuleTester` ([#17023](eslint/eslint#17023)) (Brad Zacher) - [`1fbf118`](eslint/eslint@1fbf118) fix: `getFirstToken`/`getLastToken` on comment-only node ([#16889](eslint/eslint#16889)) (Francesco Trotta) - [`129e252`](eslint/eslint@129e252) fix: Fix typo in `logical-assignment-operators` rule description ([#17000](eslint/eslint#17000)) (Francesco Trotta) #### Documentation - [`75339df`](eslint/eslint@75339df) docs: fix typos and missing info in id-match docs ([#17029](eslint/eslint#17029)) (Ed Lucas) - [`ec2d830`](eslint/eslint@ec2d830) docs: Fix typos in the `semi` rule docs ([#17012](eslint/eslint#17012)) (Andrii Lundiak) - [`e39f28d`](eslint/eslint@e39f28d) docs: add back to top button ([#16979](eslint/eslint#16979)) (Tanuj Kanti) - [`721c717`](eslint/eslint@721c717) docs: Custom Processors cleanup and expansion ([#16838](eslint/eslint#16838)) (Ben Perlmutter) - [`d049f97`](eslint/eslint@d049f97) docs: 'How ESLint is Maintained' page ([#16961](eslint/eslint#16961)) (Ben Perlmutter) - [`5251a92`](eslint/eslint@5251a92) docs: Describe guard options for guard-for-in ([#16986](eslint/eslint#16986)) (alope107) - [`6157d81`](eslint/eslint@6157d81) docs: Add example to guard-for-in docs. ([#16983](eslint/eslint#16983)) (alope107) - [`fd47998`](eslint/eslint@fd47998) docs: update `Array.prototype.toSorted` specification link ([#16982](eslint/eslint#16982)) (Milos Djermanovic) - [`3e1cf6b`](eslint/eslint@3e1cf6b) docs: Copy edits on Maintain ESLint docs ([#16939](eslint/eslint#16939)) (Ben Perlmutter) #### Chores - [`c67f299`](eslint/eslint@c67f299) chore: upgrade [@eslint/js](https://github.com/eslint/js)[@8](https://github.com/8).37.0 ([#17033](eslint/eslint#17033)) (Milos Djermanovic) - [`ee9ddbd`](eslint/eslint@ee9ddbd) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (ESLint Jenkins) - [`dddb475`](eslint/eslint@dddb475) chore: upgrade [@eslint/eslintrc](https://github.com/eslint/eslintrc)[@2](https://github.com/2).0.2 ([#17032](eslint/eslint#17032)) (Milos Djermanovic) - [`522431e`](eslint/eslint@522431e) chore: upgrade [email protected] ([#17031](eslint/eslint#17031)) (Milos Djermanovic) - [`f5f9a88`](eslint/eslint@f5f9a88) chore: upgrade [email protected] ([#17030](eslint/eslint#17030)) (Milos Djermanovic) - [`4dd8d52`](eslint/eslint@4dd8d52) ci: bump actions/stale from 7 to 8 ([#17026](eslint/eslint#17026)) (dependabot\[bot]) - [`ad9dd6a`](eslint/eslint@ad9dd6a) chore: remove duplicate scss, ([#17005](eslint/eslint#17005)) (Strek) - [`ada6a3e`](eslint/eslint@ada6a3e) ci: unpin Node 19 ([#16993](eslint/eslint#16993)) (Milos Djermanovic) - [`c3da975`](eslint/eslint@c3da975) chore: Remove triage label from template ([#16990](eslint/eslint#16990)) (Nicholas C. Zakas) - [`69bc0e2`](eslint/eslint@69bc0e2) ci: pin Node 19 to 19.7.0 ([#16987](eslint/eslint#16987)) (Milos Djermanovic) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1834 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>

mdjermanovic · 2023-06-08T15:58:26Z

@alundiak could you please submit the same changes again, in a new PR, as we had to undo them due to #17225.

credits: https://github.com/alundiak Refs: * eslint#17225 * eslint#17012

credits: https://github.com/alundiak Refs: * #17225 * #17012

docs: Fixed typos in semi.md

6a72a12

alundiak requested a review from a team as a code owner March 22, 2023 08:26

eslint-github-bot Bot added documentation Relates to ESLint's documentation triage An ESLint team member will look at this issue soon labels Mar 22, 2023

mdjermanovic reviewed Mar 22, 2023

View reviewed changes

mdjermanovic mentioned this pull request Mar 22, 2023

Bot still adds Triage labels to PRs eslint/eslint-github-bot#192

Closed

mdjermanovic added rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Mar 27, 2023

mdjermanovic approved these changes Mar 27, 2023

View reviewed changes

mdjermanovic merged commit ec2d830 into eslint:main Mar 27, 2023

alundiak deleted the semi-md-fix branch March 27, 2023 18:49

mdjermanovic mentioned this pull request May 27, 2023

Bug: Documentation licensed under non-OSS compatible license #17225

Closed

aladdin-add pushed a commit to aladdin-add/eslint that referenced this pull request Jun 15, 2023

docs: resubmit pr17012 doc changes

fe9946b

credits: https://github.com/alundiak Refs: * eslint#17225 * eslint#17012

aladdin-add mentioned this pull request Jun 15, 2023

docs: resubmit pr17012 doc changes #17293

Merged

1 task

aladdin-add added a commit to aladdin-add/eslint that referenced this pull request Jun 15, 2023

docs: resubmit pr17012 doc changes

fa7b82f

credits: https://github.com/alundiak Refs: * eslint#17225 * eslint#17012

mdjermanovic pushed a commit that referenced this pull request Jun 16, 2023

docs: resubmit pr17012 doc changes (#17293)

372722e

credits: https://github.com/alundiak Refs: * #17225 * #17012

eslint-github-bot Bot locked and limited conversation to collaborators Sep 24, 2023

eslint-github-bot Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

docs: Fixed typos in `semi.md`#17012

docs: Fixed typos in `semi.md`#17012
mdjermanovic merged 1 commit intoeslint:mainfrom
alundiak:semi-md-fix

alundiak commented Mar 22, 2023 •

edited

Loading

Uh oh!

linux-foundation-easycla Bot commented Mar 22, 2023 •

edited

Loading

Uh oh!

netlify Bot commented Mar 22, 2023 •

edited

Loading

Uh oh!

mdjermanovic Mar 22, 2023

Uh oh!

alundiak Mar 22, 2023 •

edited

Loading

Uh oh!

alundiak Mar 22, 2023 •

edited

Loading

Uh oh!

fasttime Mar 26, 2023

Uh oh!

mdjermanovic Mar 27, 2023

Uh oh!

mdjermanovic left a comment

Uh oh!

mdjermanovic commented Jun 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

alundiak commented Mar 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Uh oh!

linux-foundation-easycla Bot commented Mar 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Mar 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for docs-eslint ready!

Uh oh!

mdjermanovic Mar 22, 2023

Choose a reason for hiding this comment

Uh oh!

alundiak Mar 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alundiak Mar 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fasttime Mar 26, 2023

Choose a reason for hiding this comment

Uh oh!

mdjermanovic Mar 27, 2023

Choose a reason for hiding this comment

Uh oh!

mdjermanovic left a comment

Choose a reason for hiding this comment

Uh oh!

mdjermanovic commented Jun 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alundiak commented Mar 22, 2023 •

edited

Loading

linux-foundation-easycla Bot commented Mar 22, 2023 •

edited

Loading

netlify Bot commented Mar 22, 2023 •

edited

Loading

alundiak Mar 22, 2023 •

edited

Loading

alundiak Mar 22, 2023 •

edited

Loading