-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Closed
Labels
acceptedThere is consensus among the team that this change meets the criteria for inclusionThere is consensus among the team that this change meets the criteria for inclusioncoreRelates to ESLint's core APIs and featuresRelates to ESLint's core APIs and featuresdocumentationRelates to ESLint's documentationRelates to ESLint's documentation
Description
Docs page(s)
What documentation issue do you want to solve?
The following three "> I hope to ..." lines seem like internal comments that were put on the full website?
| > I hope to rename `set` field or replace by a method. |
| > I hope to deprecate `functionExpressionScope` field as replacing by `scope.type === "function-expression-name"`. |
| > I hope to deprecate `identifiers` field as replacing by `defs[].name` field. |
What do you think is the correct solution?
It seems to me that these are old comments that just have stayed on the website for a very long time. They should probably be deleted, I'd think?
Participation
- I am willing to submit a pull request for this change.
Additional comments
Git blame points to: 1c2aafd
Metadata
Metadata
Assignees
Labels
acceptedThere is consensus among the team that this change meets the criteria for inclusionThere is consensus among the team that this change meets the criteria for inclusioncoreRelates to ESLint's core APIs and featuresRelates to ESLint's core APIs and featuresdocumentationRelates to ESLint's documentationRelates to ESLint's documentation
Type
Projects
Status
Complete