Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: eslint/eslint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.15.2
Choose a base ref
...
head repository: eslint/eslint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.15.3
Choose a head ref
  • 4 commits
  • 26 files changed
  • 3 contributors

Commits on Mar 15, 2019

  1. Configuration menu
    Copy the full SHA
    1f715a2 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2019

  1. Fix: avoid moving comments in implicit-arrow-linebreak (fixes #11521) (

    …#11522)
    
    Currently, the implicit-arrow-linebreak rule contains a lot of logic to determine how comments should be adjusted in code when an autofix is needed. The goal is to be able to autofix cases where there is a comment between an arrow token and the start of an arrow function body. Most other core rules simply decide not to fix cases when there is a comment interfering with the fix.
    
    This logic accounts for a large fraction of the code in the rule, and seems to require a lot of different code for many individual cases. Unfortunately, bugs keep being reported identifying problems in the rule (e.g. #11268, #11521) and it's not clear that the fixes are moving us closer to making the rule correct in general, given that there are always more cases than we can explicitly account for.
    
    To address those problems, this commit updates the implicit-arrow-linebreak rule to just skip autofixing when comments interfere, rather than trying to do an autofix anyway and find an alternate location for the comments. I'm reluctant to make this change given that a lot of time has been invested in the autofixing logic, but I think this is ultimately a better solution than trying to guess where the user wants their comments to go, and crashing/producing incorrect code if we get it wrong.
    not-an-aardvark authored Mar 18, 2019
    Configuration menu
    Copy the full SHA
    71adc66 View commit details
    Browse the repository at this point in the history
  2. Build: changelog update for 5.15.3

    ESLint Jenkins committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    cb57316 View commit details
    Browse the repository at this point in the history
  3. 5.15.3

    ESLint Jenkins committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    a6168f8 View commit details
    Browse the repository at this point in the history
Loading