Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: eslint/eslint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5ac9b63
Choose a base ref
...
head repository: eslint/eslint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: faf3c4e
Choose a head ref
  • 12 commits
  • 131 files changed
  • 10 contributors

Commits on Jan 10, 2019

  1. Docs: Improve custom formatter docs (#11258) 

    * Docs: Improve custom formatter docs

* Fix lint errors and add comment
    @nzakas
    nzakas authored Jan 10, 2019
    Configuration menu
    Copy the full SHA
    9c31625 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2019

  1. Docs: fixes typo peerDepencies (#11252)

    @chrkhl @kaicataldo
    chrkhl authored and kaicataldo committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    da9174e View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2019

  1. Docs: Add npx usage to Getting Started guide (#11249) 

    * Docs: Add `npx` usage to Getting Started guide

`npx` is a shorter alternative to navigating to the executable found in `node_modules/.bin`

* Docs: Add caveats of using `npx`

* Docs: Use a suggested alternative phrasing
    @nzakas
    eyal0803 authored and nzakas committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    7c0bf2c View commit details
    Browse the repository at this point in the history

  2. Docs: fix example for sort-imports ignoreDeclarationSort (#11242)

    @remcohaszing @nzakas
    remcohaszing authored and nzakas committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    000f495 View commit details
    Browse the repository at this point in the history

  3. Fix: Manage severity of 1 with TAP reporter (fixes #11110) (#11221) 

    When using TAP reporter, both messages with severity of 1 or 2 were listed as errors (`not ok`). This changes aims at reporting warnings as `ok` messages.
    @GabrielCousin @nzakas
    GabrielCousin authored and nzakas committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    9194f45 View commit details
    Browse the repository at this point in the history

  4. Fix: warn constant on RHS of || in no-constant-condition (fixes #11181)… 

    … (#11253)

* Fix: handling of string literals on the right side of logical OR (fixes #11181)

* Fix: handling of string literals on the right side of logical OR (fixes #11181)
    @kaicataldo
    Merlin Mason authored and kaicataldo committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    c403445 View commit details
    Browse the repository at this point in the history

  5. Docs: add @g-plane as committer (#11277)

    @kaicataldo
    kaicataldo authored Jan 16, 2019
    Configuration menu
    Copy the full SHA
    3ffcf26 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2019

  1. Docs: clarify process for adding committers (#11272) 

    * Docs: clarify process for adding committers

* Update instructions to not include emailing twice.
    @kaicataldo
    kaicataldo authored Jan 17, 2019
    Configuration menu
    Copy the full SHA
    04450bb View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2019

  1. Fix: avoid loading core rules dynamically from FS in Linter (#11278)

    @petermetz @not-an-aardvark
    petermetz authored and not-an-aardvark committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    aa56247 View commit details
    Browse the repository at this point in the history

  2. Chore: use meta.messages in some rules (2/4) (refs #9870) (#10773) 

    * Chore: use meta.messages in global-require

* Chore: use meta.messages in guard-for-in

* Chore: use meta.messages in handle-callback-err

* Chore: use meta.messages in id-blacklist

* Chore: use meta.messages in id-length

* Chore: use meta.messages in id-match

* Chore: use meta.messages in implicit-linebreak

* Chore: use meta.messages in indent-legacy

* Chore: use meta.messages in indent

* Chore: use meta.messages in jsx-quotes

* Chore: use meta.messages in init-declarations

* Chore: use messageId in rule key-spacing

* Chore: use messageId in rule linebreak-style

Signed-off-by: weiran.zsd <[email protected]>

* Chore: use messageId in rule max-len

Signed-off-by: weiran.zsd <[email protected]>

* Chore: use messageId in rule line-comment-position

Signed-off-by: weiran.zsd <[email protected]>

* Chore: use messageId in rule lines-around-comment

Signed-off-by: weiran.zsd <[email protected]>

* Chore: use messageId in rule lines-around-directive

Signed-off-by: weiran.zsd <[email protected]>

* Chore: use messageId in rule lines-between-class-members

Signed-off-by: weiran.zsd <[email protected]>

* Chore: use messageId in rule max-depth

Signed-off-by: weiran.zsd <[email protected]>

* global-require

Signed-off-by: weiran.zsd <[email protected]>

* Chore: use messageId in rule max-lines-per-functions

Signed-off-by: weiran.zsd <[email protected]>

* Chore: use messageId in rule max-lines

Signed-off-by: weiran.zsd <[email protected]>

* Chore: use messageId in rule max-nested-callbacks

* Chore: use messageId in rule max-params

* Chore: use messageId in rule max-statements-per-line

* Chore: use messageId in rule max-statements-per-function

* Chore: fix max-lines-per-function

* Chore: use messageId in rule max-statements

* Chore: use messageId in rule new-cap

* Chore: use messageId in rule multiline-ternary

* Chore: use messageId in rule multiline-comment-style

* Chore: use messageId in rule newline-after-var

* Chore: use messageId in rule new-parens

* Chore: use messageId in rule newline-before-return

* Chore: use messageId in rule newline-per-chained-call

* Chore: use messageId in rule no-async-promise-executor

* Chore: use messageId in rule keyword-spacing

* Chore: use messageId in rule yoda

* Chore: fix wrap-iife (+1 squashed commits)

Squashed commits:

[9959b8f] Chore: use messageId in rule wrap-iife

* Chore: use messageId in rule unicode-bom

* Chore: use messageId in rule use-isnan

Signed-off-by: weiran.zsd <[email protected]>

* Chore: use messageId in rule valid-typeof

Signed-off-by: weiran.zsd <[email protected]>

* Chore: use messageId in rule vars-on-top

Signed-off-by: weiran.zsd <[email protected]>

* Chore: use messageId in rule yield-star-spacing

* Chore: use messageId in rule valid-jsdoc

* Chore: use messageId in rule template-curly-spacing

* Chore: use messageId in rule template-tag-spacing

* Chore: use meta.messages in switch-colon-spacing

* Chore: use meta.messages in strict

* Chore: use meta.messages in symbol-description

* Chore: use meta.messages in no-duplicate-import

* Chore: use meta.messages in no-fallthrough

* Chore: use meta.messages in space-unary-ops

* Fix: rule spae-unary-ops messages

* Chore: use messageId in rule space-unary-ops

* Chore: use messages in rule no-floating-decimal

* Chore: use messages in rule no-invalid-meta

* Fix: rule space-unary-ops messages

* Chore: use messages in rule no-unexpected-multiline

* Chore: use messages in rule no-unsafe-negation

* Chore: use messages in rule no-undef

* Chore: use messages in rule no-unused-labels

* Chore: use messages in rule operator-assignment

* Chore: use messages in rule prefer-const

* Chore: fix failing tests

* Chore: fix cli-engine tests failing

Signed-off-by: weiran.zsd <[email protected]>

* Chore: convert no-unsafe-negation to single messagesId + data (+3 squashed commits)
Squashed commits:
[407f0f2] Fix: yield-star-spacing messages

Signed-off-by: weiran.zsd <[email protected]>
[66ab408] Chore: do not dynamically generating messageId
[ff4a3b12] Chore: indent rule messageId expected => wrongIndentation
    @aladdin-add @kaicataldo
    aladdin-add authored and kaicataldo committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    eb5c401 View commit details
    Browse the repository at this point in the history

  3. Build: changelog update for 5.12.1

    ESLint Jenkins committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    1010c98 View commit details
    Browse the repository at this point in the history

  4. 5.12.1

    ESLint Jenkins committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    faf3c4e View commit details
    Browse the repository at this point in the history
Loading