Fix broken unit tests caused by stubbed process.version

aryaemami59 · antfu · aryaemami59 · commit f339591ce360 · 2024-05-29T07:18:06.000-05:00
Co-authored-by: Anthony Fu &lt;anthonyfu117@hotmail.com&gt;
diff --git a/tests/lib/cli-engine/lint-result-cache.js b/tests/lib/cli-engine/lint-result-cache.js
@@ -163,16 +163,21 @@ describe("LintResultCache", () => {
             it("contains node version during hashing", () => {
                 const version = "node-=-version";
 
-                sandbox.stub(process, "version").value(version);
-                const NewLintResultCache = proxyquire("../../../lib/cli-engine/lint-result-cache.js", {
-                    "./hash": hashStub
-                });
-                const newLintResultCache = new NewLintResultCache(cacheFileLocation, "metadata");
+                const versionStub = sandbox.stub(process, "version").value(version);
 
-                newLintResultCache.getCachedLintResults(filePath, fakeConfig);
+                try {
+                    const NewLintResultCache = proxyquire("../../../lib/cli-engine/lint-result-cache.js", {
+                        "./hash": hashStub
+                    });
+                    const newLintResultCache = new NewLintResultCache(cacheFileLocation, "metadata");
 
-                assert.ok(hashStub.calledOnce);
-                assert.ok(hashStub.calledWithMatch(version));
+                    newLintResultCache.getCachedLintResults(filePath, fakeConfig);
+
+                    assert.ok(hashStub.calledOnce);
+                    assert.ok(hashStub.calledWithMatch(version));
+                } finally {
+                    versionStub.restore();
+                }
             });
         });
 
