Chore: upgrade eslint-plugin-eslint-plugin (#14738)

aladdin-add · web-flow · commit f113cdd87225 · 2021-06-23T12:11:07.000+02:00
diff --git a/lib/rules/dot-notation.js b/lib/rules/dot-notation.js
@@ -94,7 +94,7 @@ module.exports = {
 
                         // Don't perform any fixes if there are comments inside the brackets.
                         if (sourceCode.commentsExistBetween(leftBracket, rightBracket)) {
-                            return; // eslint-disable-line eslint-plugin/fixer-return -- false positive
+                            return;
                         }
 
                         // Replace the brackets by an identifier.
@@ -154,12 +154,12 @@ module.exports = {
 
                             // A statement that starts with `let[` is parsed as a destructuring variable declaration, not a MemberExpression.
                             if (node.object.type === "Identifier" && node.object.name === "let" && !node.optional) {
-                                return; // eslint-disable-line eslint-plugin/fixer-return -- false positive
+                                return;
                             }
 
                             // Don't perform any fixes if there are comments between the dot and the property name.
                             if (sourceCode.commentsExistBetween(dotToken, node.property)) {
-                                return; // eslint-disable-line eslint-plugin/fixer-return -- false positive
+                                return;
                             }
 
                             // Replace the identifier to brackets.
diff --git a/lib/rules/prefer-arrow-callback.js b/lib/rules/prefer-arrow-callback.js
@@ -295,7 +295,7 @@ module.exports = {
                                  * If the callback function has duplicates in its list of parameters (possible in sloppy mode),
                                  * don't replace it with an arrow function, because this is a SyntaxError with arrow functions.
                                  */
-                                return; // eslint-disable-line eslint-plugin/fixer-return -- false positive
+                                return;
                             }
 
                             // Remove `.bind(this)` if exists.
@@ -307,7 +307,7 @@ module.exports = {
                                  * E.g. `(foo || function(){}).bind(this)`
                                  */
                                 if (memberNode.type !== "MemberExpression") {
-                                    return; // eslint-disable-line eslint-plugin/fixer-return -- false positive
+                                    return;
                                 }
 
                                 const callNode = memberNode.parent;
@@ -320,12 +320,12 @@ module.exports = {
                                  *                    ^^^^^^^^^^^^
                                  */
                                 if (astUtils.isParenthesised(sourceCode, memberNode)) {
-                                    return; // eslint-disable-line eslint-plugin/fixer-return -- false positive
+                                    return;
                                 }
 
                                 // If comments exist in the `.bind(this)`, don't remove those.
                                 if (sourceCode.commentsExistBetween(firstTokenToRemove, lastTokenToRemove)) {
-                                    return; // eslint-disable-line eslint-plugin/fixer-return -- false positive
+                                    return;
                                 }
 
                                 yield fixer.removeRange([firstTokenToRemove.range[0], lastTokenToRemove.range[1]]);
diff --git a/package.json b/package.json
@@ -95,7 +95,7 @@
     "ejs": "^3.0.2",
     "eslint": "file:.",
     "eslint-config-eslint": "file:packages/eslint-config-eslint",
-    "eslint-plugin-eslint-plugin": "^3.0.3",
+    "eslint-plugin-eslint-plugin": "^3.2.0",
     "eslint-plugin-internal-rules": "file:tools/internal-rules",
     "eslint-plugin-jsdoc": "^25.4.3",
     "eslint-plugin-node": "^11.1.0",

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ module.exports = {`
`94`	`94`
`95`	`95`	`// Don't perform any fixes if there are comments inside the brackets.`
`96`	`96`	`if (sourceCode.commentsExistBetween(leftBracket, rightBracket)) {`
`97`		`- return; // eslint-disable-line eslint-plugin/fixer-return -- false positive`
	`97`	`+ return;`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`// Replace the brackets by an identifier.`
`@@ -154,12 +154,12 @@ module.exports = {`
`154`	`154`
`155`	`155`	// A statement that starts with `let[` is parsed as a destructuring variable declaration, not a MemberExpression.
`156`	`156`	`if (node.object.type === "Identifier" && node.object.name === "let" && !node.optional) {`
`157`		`- return; // eslint-disable-line eslint-plugin/fixer-return -- false positive`
	`157`	`+ return;`
`158`	`158`	`}`
`159`	`159`
`160`	`160`	`// Don't perform any fixes if there are comments between the dot and the property name.`
`161`	`161`	`if (sourceCode.commentsExistBetween(dotToken, node.property)) {`
`162`		`- return; // eslint-disable-line eslint-plugin/fixer-return -- false positive`
	`162`	`+ return;`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`// Replace the identifier to brackets.`