refactor: remove unnecessary use of SourceCode#getAncestors in rules (#17075)

mdjermanovic · web-flow · commit eac4943ba2e4 · 2023-04-11T12:24:28.000-07:00
diff --git a/lib/rules/no-lone-blocks.js b/lib/rules/no-lone-blocks.js
@@ -76,7 +76,7 @@ module.exports = {
                 return;
             }
 
-            const block = sourceCode.getAncestors(node).pop();
+            const block = node.parent;
 
             if (loneBlocks[loneBlocks.length - 1] === block) {
                 loneBlocks.pop();
diff --git a/lib/rules/no-lonely-if.js b/lib/rules/no-lonely-if.js
@@ -32,9 +32,8 @@ module.exports = {
 
         return {
             IfStatement(node) {
-                const ancestors = sourceCode.getAncestors(node),
-                    parent = ancestors.pop(),
-                    grandparent = ancestors.pop();
+                const parent = node.parent,
+                    grandparent = parent.parent;
 
                 if (parent && parent.type === "BlockStatement" &&
                         parent.body.length === 1 && grandparent &&
diff --git a/lib/rules/no-unused-expressions.js b/lib/rules/no-unused-expressions.js
@@ -70,8 +70,7 @@ module.exports = {
             allowShortCircuit = config.allowShortCircuit || false,
             allowTernary = config.allowTernary || false,
             allowTaggedTemplates = config.allowTaggedTemplates || false,
-            enforceForJSX = config.enforceForJSX || false,
-            sourceCode = context.getSourceCode();
+            enforceForJSX = config.enforceForJSX || false;
 
         /**
          * Has AST suggesting a directive.
@@ -110,12 +109,11 @@ module.exports = {
         /**
          * Detect if a Node is a directive.
          * @param {ASTNode} node any node
-         * @param {ASTNode[]} ancestors the given node's ancestors
          * @returns {boolean} whether the given node is considered a directive in its current position
          */
-        function isDirective(node, ancestors) {
-            const parent = ancestors[ancestors.length - 1],
-                grandparent = ancestors[ancestors.length - 2];
+        function isDirective(node) {
+            const parent = node.parent,
+                grandparent = parent.parent;
 
             /**
              * https://tc39.es/ecma262/#directive-prologue
@@ -181,7 +179,7 @@ module.exports = {
 
         return {
             ExpressionStatement(node) {
-                if (Checker.isDisallowed(node.expression) && !isDirective(node, sourceCode.getAncestors(node))) {
+                if (Checker.isDisallowed(node.expression) && !isDirective(node)) {
                     context.report({ node, messageId: "unusedExpression" });
                 }
             }
diff --git a/lib/rules/valid-typeof.js b/lib/rules/valid-typeof.js
@@ -83,7 +83,7 @@ module.exports = {
 
             UnaryExpression(node) {
                 if (isTypeofExpression(node)) {
-                    const parent = sourceCode.getAncestors(node).pop();
+                    const { parent } = node;
 
                     if (parent.type === "BinaryExpression" && OPERATORS.has(parent.operator)) {
                         const sibling = parent.left === node ? parent.right : parent.left;
diff --git a/lib/rules/wrap-regex.js b/lib/rules/wrap-regex.js
@@ -40,10 +40,9 @@ module.exports = {
                 if (nodeType === "RegularExpression") {
                     const beforeToken = sourceCode.getTokenBefore(node);
                     const afterToken = sourceCode.getTokenAfter(node);
-                    const ancestors = sourceCode.getAncestors(node);
-                    const grandparent = ancestors[ancestors.length - 1];
+                    const { parent } = node;
 
-                    if (grandparent.type === "MemberExpression" && grandparent.object === node &&
+                    if (parent.type === "MemberExpression" && parent.object === node &&
                         !(beforeToken && beforeToken.value === "(" && afterToken && afterToken.value === ")")) {
                         context.report({
                             node,
diff --git a/lib/rules/yoda.js b/lib/rules/yoda.js
@@ -343,7 +343,7 @@ module.exports = {
                     ) &&
                     !(!isEqualityOperator(node.operator) && onlyEquality) &&
                     isComparisonOperator(node.operator) &&
-                    !(exceptRange && isRangeTest(sourceCode.getAncestors(node).pop()))
+                    !(exceptRange && isRangeTest(node.parent))
                 ) {
                     context.report({
                         node,

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ module.exports = {`
`76`	`76`	`return;`
`77`	`77`	`}`
`78`	`78`
`79`		`- const block = sourceCode.getAncestors(node).pop();`
	`79`	`+ const block = node.parent;`
`80`	`80`
`81`	`81`	`if (loneBlocks[loneBlocks.length - 1] === block) {`
`82`	`82`	`loneBlocks.pop();`